Repository navigation
True streaming packages: format entities as Packages (#35) - #36
Merged
Merged
Conversation
- XlsBiffRecord is BinaryPackage; parser emits one-record owned slices - Xml cell/row/merge/hyperlink types live under Reader/Xml as XmlPackage - ZipWorker streams ZIP entries (no full extract-to-temp) - Document progressive parse/render contract in docs/streaming-packages.md Co-authored-by: Fan Feilong <fanfeilong@gmail.com>
fanfeilong
marked this pull request as ready for review
September 23, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Design
Network-oriented streaming: Parser recognizes a local complete format unit and emits it as a Package immediately so a renderer can progress without waiting for EOF.
Changes
XlsBiffRecord : BinaryPackage— Binary format entities are packages (no wrapper type)BinaryPackageParser— emits one-record owned byte slices viaTryRead/Parse(OLE sector assemble still needed for compound files; record emit is one-package-at-a-time)Reader/Xml— cell/row/merge/hyperlink areXmlPackageformat unitsZipWorker— keeps ZIP open and streams entry inflate (GetInputStream); no full extract-to-tempdocs/streaming-packages.md— progressive parse/render contract + known gap for non-seekable network ZIPVerify
src/test.sh— allDone!(exit 0)