Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The only remaining finding is a non-blocking test-coverage nit.
Pull request overview
Removes legacy JSON WebSocket protocol support, leaving binary protocol transport only.
Changes:
- Removes legacy transport models and tests.
- Removes the
mashumarodependency and lockfile entries. - Updates transport tests for binary frames and handler errors.
Review note: Add coverage rejecting the former JSON text hello; this is a non-blocking nit.
File summaries
| File | Description |
|---|---|
zigpy_ziggurat/zigbee/transport.py |
Restricts transport to binary frames. |
zigpy_ziggurat/zigbee/legacy.py |
Removes legacy JSON models. |
uv.lock |
Updates locked dependencies. |
tests/test_transport.py |
Updates binary transport coverage. |
tests/test_legacy.py |
Removes obsolete legacy tests. |
pyproject.toml |
Removes mashumaro. |
Review details
Suppressed comments (1)
zigpy_ziggurat/zigbee/transport.py:180
- The legacy-removal behavior is not covered by the updated transport tests: they only exercise a binary hello and a closing handshake. Please add a server/test case that sends the former JSON text hello and asserts
connect_transport()rejects it, so the compatibility boundary is protected against accidental reintroduction or incorrect handshake handling.
if hello.type != aiohttp.WSMsgType.BINARY:
- Files reviewed: 5/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #7 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 6 -1
Lines 1681 1185 -496
==========================================
- Hits 1681 1185 -496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3 brought support for Ziggurat's binary protocol while adding a transparent shim to support the provisional JSON format. It's been a few releases and I think anybody using Ziggurat would have updated their Ziggurat addon a few times by now. It's time we remove the backwards compat.