Skip to content

chore: version bump - #36

Closed
zhukeev wants to merge 1 commit into
mainfrom
feat/new_version_25
Closed

chore: version bump#36
zhukeev wants to merge 1 commit into
mainfrom
feat/new_version_25

Conversation

@zhukeev

@zhukeev zhukeev commented Apr 27, 2026

Copy link
Copy Markdown
Owner

No description provided.

@zhukeev zhukeev self-assigned this Apr 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 1.0.25, adds Tizen support to the documentation, and adjusts dependency versions and the Dart SDK constraint in the example project. It also cleans up unused imports across several files. However, a critical issue was identified in lib/models/spoiler_drawing_strategy.dart where the removal of the dart:typed_data import will cause compilation errors because types like Float32List and Int32List are used within the file.

@@ -1,5 +1,5 @@
import 'dart:math';
import 'dart:typed_data';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The removal of import 'dart:typed_data'; will cause compilation errors. The types Float32List and Int32List used extensively in this file (e.g., in the RawAtlasPainter typedef and the AtlasSpoilerDrawer class) are defined in the dart:typed_data library. These types are not re-exported by the Flutter framework imports such as package:flutter/foundation.dart or package:flutter/material.dart.

Suggested change
import 'dart:typed_data';

@zhukeev zhukeev closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant