Feat/tizen support - #35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a rendering fallback system for the spoiler widget, enabling a transition from atlas-based rendering to a new vector-based approach when hardware acceleration is unavailable or particles are below a certain size threshold. The changes include a refactored drawing strategy hierarchy, updated image factory utilities, and comprehensive unit tests. Review feedback identifies critical issues in the scaling logic for both drawers: the atlas drawer incorrectly maps raster dimensions to logical coordinates, and the vector drawer fails to normalize custom path bounds, leading to incorrectly sized shapes.
zhukeev
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed some file so now can support tizen based devices specifically for Samsung devices