Skip to content

Feat/tizen support - #35

Merged
zhukeev merged 5 commits into
zhukeev:mainfrom
MohammadAsefPoya:feat/tizen-support
Apr 27, 2026
Merged

Feat/tizen support#35
zhukeev merged 5 commits into
zhukeev:mainfrom
MohammadAsefPoya:feat/tizen-support

Conversation

@MohammadAsefPoya

Copy link
Copy Markdown
Contributor

I changed some file so now can support tizen based devices specifically for Samsung devices

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a rendering fallback system for the spoiler widget, enabling a transition from atlas-based rendering to a new vector-based approach when hardware acceleration is unavailable or particles are below a certain size threshold. The changes include a refactored drawing strategy hierarchy, updated image factory utilities, and comprehensive unit tests. Review feedback identifies critical issues in the scaling logic for both drawers: the atlas drawer incorrectly maps raster dimensions to logical coordinates, and the vector drawer fails to normalize custom path bounds, leading to incorrectly sized shapes.

Comment thread lib/models/spoiler_drawing_strategy.dart
Comment thread lib/models/spoiler_drawing_strategy.dart
@zhukeev
zhukeev merged commit d113664 into zhukeev:main Apr 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants