Repository navigation
Clarify TUI sampling semantics and preserve socket baselines - #141
Merged
Merged
Conversation
Changes: - Distinguish current memory, cumulative reductions, signed window changes, and reductions per second measured with monotonic time. - Show warm-up, missing samples, and counter resets explicitly, and preserve socket baselines across sort, page, and refresh changes. - Keep recon-style mode expressions in a compact, width-aware header and label used versus allocated memory without changing data sources or the CLI schema. - Add regression coverage for sampling, real UDP traffic, pause/resume, socket identity, baseline resets, and terminal layout; document the display contract. Validation: - After rebasing onto main, rebar3 eunit passed all 811 tests on OTP 28.0.2. - mise exec erlang@28.5 -- rebar3 as ci check passed compilation, lint, formatting, xref, Dialyzer, and documentation generation. - The default OTP 28.0.2 quality run reached ExDoc but failed on unavailable re:import/1; the complete check passed using installed OTP 28.5 without project configuration changes. - scripts/escript-smoke.sh passed all 17 cases, including remote TUI stdin EOF cleanup. - rebar3 fmt --check and git diff --check passed; captured terminal output verified heap count/window switching, warm-up, and measured sample timing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 97.85% 97.81% -0.05%
==========================================
Files 24 24
Lines 7939 8064 +125
==========================================
+ Hits 7769 7888 +119
- Misses 170 176 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Changes: - Pin the OTP 29 test job, Mix job, and OTP 26 cross-version target to OTP 29.1.1 while retaining OTP 26-28 compatibility coverage. - Keep major-version check names, release artifact names, and coverage-upload gates unchanged. - Set the Codecov project target to 95%, preserving the 50% patch target and zero thresholds. Validation: - Parsed both YAML files and asserted resolved OTP versions, compatibility matrix entries, stable check/artifact names, upload gates, and coverage targets. - With the local default upgraded to OTP 29.1.1, mise exec -- rebar3 as ci check passed compilation, lint, formatting, xref, Dialyzer, and documentation generation. - mise exec -- rebar3 eunit passed all 811 tests on OTP 29.1.1. - mise exec -- scripts/escript-smoke.sh passed all 17 cases on OTP 29.1.1. - git diff --check passed; hosted CI will validate the updated workflow after push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the measurement contract in the interactive Home, Sockets, and System views without changing their memory data sources or the versioned CLI response schema.
Reds total, signedchangecolumns, andReds/scalculated from actual monotonic elapsed time.warming upinstead of lifetime totals in first-window results. Keep missing samples, counter resets, and pause/resume visible; preserve negative memory/heap/queue changes.recon:proc_count(...)/recon:proc_window(...)expressions. Prefer a single navigation/status row, hide zero missing/reset counts, and wrap without truncating important status on narrow terminals.change/chg, distinguish socket window counters from lifetime maxima, and explicitly label Home's used memory versus System's allocated memory.CI and local runtime follow-up
Validation
Rebased onto current
main(30bfc1a) before final validation.mise exec -- rebar3 eunit— 811 tests passed on the new default OTP 29.1.1.mise exec -- rebar3 as ci check(OTP 29.1.1) — passed compilation, lint, formatting, xref, Dialyzer, and HTML/Markdown/EPUB documentation generation.mise exec -- scripts/escript-smoke.sh(OTP 29.1.1) — 17 cases passed, including remote TUI cleanup on stdin EOF.rebar3 fmt --checkandgit diff --check— passed.The former OTP 28.0.2 default had an ExDoc
re:import/1incompatibility. The local default is now OTP 29.1.1, and the complete quality check, including ExDoc, passes without a per-command version override. Both YAML files were parsed and their OTP selection, stable check/artifact names, upload gates, and coverage targets were validated.Scope and compatibility