Conversation
We were missing a host of newly added extensions; also fix a broken quote in emissiveStrength.
Instead of treating the binary as an opaque blob, we now mutate JSON or BIN chunk explicitly during fuzzing. This is much better for fuzzing efficiency, because it allows expanding or contracting either chunk and automatically fixes up lengths, which previously one-shot mutating could not do. For now we still use the "only keep valid files in the corpus" heuristic and with this change it gets us much further, although it does still mean that the fuzzer can't really make coordinated changes across both JSON/BIN, which means it can't always get to a valid-but-problematic document through a sequence of edits.
Many algorithms during gltfpack processing need positions; we currently have early outs for all of them, but this is a bit fragile. Because position-less meshes should be skipped per specification anyway, we discard primitives like that early.
We need to pass a non-NULL pointer for the meshopt extension to avoid strcmp with NULL.
This completes the full set of names that cgltf.h recognizes, so that it's easier for the fuzzer to synthesize interesting documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of treating the binary as an opaque blob, we now mutate JSON or
BIN chunk explicitly during fuzzing. This is much better for fuzzing
efficiency, because it allows expanding or contracting either chunk and
automatically fixes up lengths, which previously one-shot mutating could
not do.
Also update fuzzing dictionary with new extensions and fix a few small
interactions.