Improve profile design#323
Conversation
|
good work @NaitYoussef |
|
@zeroual Yes that's right ! And the mobile version is no good neither :'(, Ill fix it 🔢 |
|
@NaitYoussef be aware when you rebase with master after mergin @qasmi pull request . |
|
Ok @zeroual XD, thanks |
|
lool , and i f you can improve the display of nb visits , we will appreciate that 😂 |
|
good job @NaitYoussef . you fixed all things try to change the border of .card .profile-header-background |
|
|
| <div class="panel panel-default"> | ||
| <div class="panel-body"> | ||
| <div class="row profile-header-background"style="margin-top:-20px;"> | ||
| <div class="panel-body profile-header-panel" > |
There was a problem hiding this comment.
you can move style="margin-top:-20px;" to .profile-header-background in css file
There was a problem hiding this comment.
Yes I still have to clean my code, for now I'm just trying to get some feedback !
There was a problem hiding this comment.
did you try to change the border size ?
There was a problem hiding this comment.
Yes you're right I like it more now 👍
|
@NaitYoussef i want to merge your PR but is not updated with master. |
|
and i think that you are fogot to display the visits count in profil 💯 (what @qasmi did last week ) |
|
Okay sir will rebase it today 😉 |
2 participants
No description provided.