Repository navigation
Tooltips on the icon-only buttons that had none - #1048
Open
alexandre-vl wants to merge 2 commits into
Open
alexandre-vl wants to merge 2 commits into
alexandre-vl wants to merge 2 commits into
Conversation
The comment "+" in diffs and Markdown previews, and twenty other buttons that show only a glyph, now say what they do on hover, like the rest of the app's icon buttons. Each tooltip reuses the button's accessible label or the wording its twin uses elsewhere. - Comments: the "+" adder (diffs, Markdown previews, the file editor's gutter) and the gutter's comment marker (Show / Hide comment). - Model picker: the Starred and per-agent tabs, the favorite star, and the compact picker's Back. - Pull requests: Clear search, Send comment. - Settings: accent swatches, both dialog close buttons, the background zoom − / +, the pack stepper, Cloud's repository refresh and code copy, and Providers' refresh. - Shell: the action icon picker, the section dialog's close, the voice error's dismiss, and the hidden-folders crumb. The full model picker shows the same PickerHint chip as the compact one.
Twenty-six full-window captures of the production Shell, one per tooltip the previous commit added, each taken after the hover delay. The README lists them and says how they were captured: an offscreen window, synthetic input, and an in-process engine whose account, pull request, and catalog replies are faked, so every name and number shown is invented.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons that show only a glyph, starting with the comment "+" beside a Markdown table header, now say what they do on hover, like the app's other icon buttons. Each tooltip reuses the button's accessible label, or the wording its twin uses elsewhere, in the app's existing tooltip chip.
What changes
crates/ui/src/comment_ui.rs:40), as does the file editor's gutter "+" (crates/ui/src/files/preview.rs:2927). The gutter's comment marker says "Show comment" or "Hide comment", by whether its comment is open (preview.rs:2893,:2903).crates/ui/src/pickers.rs:4904,:4945,:5394), as does the compact picker's Back (crates/ui/src/pickers/compact.rs:524). The full picker shows the compact one'sPickerHintchip, nowpub(super)(compact.rs:1473), so both pickers' tooltips look the same.crates/ui/src/pull_requests.rs:2509). The comment box's send button says "Send comment", or "Sending comment" while a send is in flight, the same text as its accessible label (crates/ui/src/pull_request_interactions.rs:245,:425).crates/ui/src/settings/appearance.rs:1903). The × on Add a theme and on Adjust background says "Close" (:2601,:3137), and the background zoom buttons say "Zoom out" and "Zoom in" (:3025,:3052).crates/ui/src/settings/billing.rs:648,:664).crates/ui/src/settings/cloud.rs:1045,:1152).crates/ui/src/settings/harnesses.rs:346).crates/ui/src/shell/actions_ui.rs:614). The section dialog's × says "Close" (crates/ui/src/shell/sidebar_sections.rs:866), the voice error's × "Dismiss" (crates/ui/src/shell/voice_stage.rs:249), and the "…" that folds New project's folder trail "Show hidden folders" (crates/ui/src/shell/spaces.rs:8351). That crumb's other tooltip, a crumb's full name past 26 characters (spaces.rs:8322,:8347), never applies to the fold, whose name is "…" (:8282), so no element gets two.docs/screenshots/icon-tooltips/holds a full-window capture of each tooltip; its README lists them and says how they were taken.Testing
cargo test -p zeron-ui --lib -- --test-threads=1atbdb4e0c4, rebased onto v0.2.124 (c04e3749): 1875 passed, 0 failed. Run in parallel, the suite aborts with SIGABRT on this Mac without this change too; CI runs it under nextest, one process per test.Shell: an offscreen window that never took focus, synthetic pointer and key events, and an in-process engine. The account, the pull requests, Billing, Cloud and the model catalog came from faked engine replies. No step sent a comment, bought credits, wrote the clipboard or opened a URL, and the voice start failed before any audio device opened.git show --check: clean.All 26 tooltips
Add comment — "+" beside a Markdown table header
Add comment — "+" in a diff line's gutter
Add comment — "+" in the file editor's gutter
Show comment — Comment marker, comment closed
Hide comment — Comment marker, comment open
Starred — Model picker's star tab
Claude Code — Model picker's agent tab
Add to favorites — A model's star, off
Remove from favorites — A model's star, on
Back — Compact picker's back arrow
Clear search — × in the board's search
Send comment — Send in the Activity comment box
Orange — An accent swatch
Close — × on Add a theme
Close — × on Adjust background
Zoom out — − beside the zoom slider
Zoom in — + beside the zoom slider
Fewer packs — − on the extra-credit packs
More packs — + on the extra-credit packs
Check repositories again — Refresh beside Choose on GitHub
Copy code — GitHub device-code chip
Check for agents and updates — Refresh beside the device menu
Test — An icon choice in Add action
Close — × on New section
Dismiss — × on the voice error
Show hidden folders — "…" in New project's folder trail
Need help on this PR? Tag
@codesmith-botwith what you need.