#361: Allow reading custom PMP properties from custom areas

[VasilevNStas]

Description

Fbe.pmp only allows accessing properties through areas defined in assets/pmp.xml. When a PMP fact has a custom area (not in the XML), accessing it via Fbe.pmp.custom_area.my_prop raises "Unknown area":

# This worked (area "hr" is in pmp.xml):
Fbe.pmp.hr.days_to_reward  # => 14 (from XML default)

# This raised (area "my_custom" is NOT in pmp.xml):
Fbe.pmp.my_custom.my_prop  # => "Unknown area 'my_custom'"

Fix

When an area is not found in pmp.xml, fall back to reading properties directly from the factbase without XML defaults or type coercion. This allows custom PMP properties to be accessed:

f = fb.insert
f.what = 'pmp'
f.area = 'my_custom'
f.my_prop = 42
Fbe.pmp.my_custom.my_prop  # => 42 (now works)

Built-in areas with XML definitions continue to work as before with defaults and type coercion.

Tests

• test_custom_area — verifies custom property is readable via custom area
• test_custom_area_without_fact — verifies nil value when no fact exists
• test_custom_area_properties — verifies properties method lists custom props

Verification

• bundle exec rubocop — 0 offenses
• bundle exec rake test — 285 tests, 0 failures

Closes #361

[edmoffo]

The fallback in the new node.nil? branch closes #361 — custom areas now route to the factbase via the captured query lambda — and the three new tests pin down the value, the missing-fact, and the properties listings. Logic is reasonable. CI is green.

Notes:

• Removing test_fail_on_wrong_area removes coverage of a previously-documented behaviour. The replacement is the right call now, but the docstring of Fbe.pmp still reads as if unknown areas are an error path. Update the YARD example around lib/fbe/pmp.rb:42 so callers know custom areas are supported and that returned pmpv carries nil for default, type, and memo outside the schema.
• Inside the custom-area class, pmpv.new(result, nil, nil, nil) means .default, .type, and .memo are nil. If any existing call site invokes those accessors it will silently lose information. Worth a one-line note in the README or method doc.
• This branch conflicts with #498 on lib/fbe/pmp.rb:95. Coordinate the merge order with #498's author.

Drop the unrelated downgrade of crate-ci/typos in .github/workflows/typos.yml.

[kreinba]

The split between known-area (with XML defaults and type coercion) and unknown-area (direct factbase read) is the right shape for issue #361, and the query lambda neatly removes the duplicated Fbe.fb chain at lines 58 and 73 of the old code. One inline note about properties returning internal columns.

[kreinba]

all_properties on a pmp fact also returns the bookkeeping columns (_id, _time, what, area), so .custom.properties will list those alongside the real PMP properties. The XML branch limits the list to entries under

. Filtering out what, area, and any leading underscore name would keep parity with the XML branch. test_custom_area_properties uses assert_includes which masks the extra entries.

[VasilevNStas]

YARD doc updated with notes about custom areas and nil default/type/memo. @edmoffo

[0crat]

@kreinba Hey! Nice work on that review 👍 You snagged +13 points this time: started with the standard +18 base, but lost -5 for having just 1 comment (our policy dings us when there's fewer than 9 comments). Your running total is now +1498 - keep crushing it! Don't forget to peek at your Zerocracy account when you get a chance.

[0crat]

@VasilevNStas Thanks for the contribution! You've earned +16 points for this: +24 as a basis; +9.3 for the 124 hits-of-code that you wrote; -8 for no code review; -9.3 to not exceed the maximum cap of 24 points. Please, keep them coming. Your running score is +1574; don't forget to check your Zerocracy account too.