Skip to content

#480: Align CI Ruby version between codecov.yml and rake.yml#499

Open
VasilevNStas wants to merge 2 commits into
zerocracy:masterfrom
VasilevNStas:fix/480-ci-ruby-version
Open

#480: Align CI Ruby version between codecov.yml and rake.yml#499
VasilevNStas wants to merge 2 commits into
zerocracy:masterfrom
VasilevNStas:fix/480-ci-ruby-version

Conversation

@VasilevNStas

@VasilevNStas VasilevNStas commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

codecov.yml uses Ruby 4.0.5 while rake.yml (the primary CI workflow) uses Ruby 3.3. The gemspec requires >=3.3, meaning 3.3 is the minimum supported version.

This drift means coverage is measured on a different Ruby version than the tests run on, which can lead to inconsistencies.

Fix

Changed codecov.yml Ruby version from 4.0.5 to 3.3 to match the rake.yml CI matrix.

Verification

  • yamllint — passes
  • Ruby YAML.load_file — valid

Closes #480

@edmoffo edmoffo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns .github/workflows/codecov.yml to Ruby 3.3, matching rake.yml and the floor declared in fbe.gemspec and README.md. Resolves #480.

Drop the unrelated downgrade of crate-ci/typos from v1.47.1 to v1.47.0 in .github/workflows/typos.yml; it does not belong in this fix.

@kreinba kreinba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns codecov.yml with the rake.yml matrix at 3.3, which also matches the >=3.3 requirement in the gemspec. Closes the drift described in #480.

@VasilevNStas VasilevNStas force-pushed the fix/480-ci-ruby-version branch from 1ac8905 to 923641c Compare June 3, 2026 19:26
@0crat

0crat commented Jun 4, 2026

Copy link
Copy Markdown

@kreinba Hey! Nice work on the review 👍 You scored +6 points this time: started with +18 as the base reward, but lost -8 for having zero comments (our policy encourages at least 9 comments to avoid the -5 penalty), and another -4 for the low hit-of-code count of just 2 (we deduct points when it's under 24). Your running total is now +1439 - keep up the momentum and don't forget to check your Zerocracy account for updates!

@0crat

0crat commented Jun 4, 2026

Copy link
Copy Markdown

@edmoffo Thanks for the review! You've earned +6 points for this contribution: +18 as a basis, -8 for absolutely no comments posted during the review, and -4 for too few hits-of-code (only 2, which is below the 24 minimum). Your running score is +1555; don't forget to check your Zerocracy account too.

@VasilevNStas VasilevNStas changed the title fix: align CI Ruby version between codecov.yml and rake.yml #480 fix: align CI Ruby version between codecov.yml and rake.yml Jun 8, 2026
@VasilevNStas VasilevNStas changed the title #480 fix: align CI Ruby version between codecov.yml and rake.yml #480: Align CI Ruby version between codecov.yml and rake.yml Jun 8, 2026
@yegor256

Copy link
Copy Markdown
Member

@VasilevNStas merge conflict here. also, this value will be shifted by renovate later, automatically. we should prohibit this in the renovate.json file

@yegor256

Copy link
Copy Markdown
Member

Please fix the merge conflicts so this pull request can be merged.

@VasilevNStas VasilevNStas force-pushed the fix/480-ci-ruby-version branch from 923641c to 61a6c58 Compare June 13, 2026 15:11
@VasilevNStas

Copy link
Copy Markdown
Contributor Author

@yegor256 plz re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Ruby version drifts between codecov.yml (4.0.5) and rake.yml (3.3)

5 participants