#480: Align CI Ruby version between codecov.yml and rake.yml#499
#480: Align CI Ruby version between codecov.yml and rake.yml#499VasilevNStas wants to merge 2 commits into
Conversation
edmoffo
left a comment
There was a problem hiding this comment.
Aligns .github/workflows/codecov.yml to Ruby 3.3, matching rake.yml and the floor declared in fbe.gemspec and README.md. Resolves #480.
Drop the unrelated downgrade of crate-ci/typos from v1.47.1 to v1.47.0 in .github/workflows/typos.yml; it does not belong in this fix.
1ac8905 to
923641c
Compare
|
@kreinba Hey! Nice work on the review 👍 You scored +6 points this time: started with +18 as the base reward, but lost -8 for having zero comments (our policy encourages at least 9 comments to avoid the -5 penalty), and another -4 for the low hit-of-code count of just 2 (we deduct points when it's under 24). Your running total is now +1439 - keep up the momentum and don't forget to check your Zerocracy account for updates! |
|
@edmoffo Thanks for the review! You've earned +6 points for this contribution: +18 as a basis, -8 for absolutely no comments posted during the review, and -4 for too few hits-of-code (only 2, which is below the 24 minimum). Your running score is +1555; don't forget to check your Zerocracy account too. |
|
@VasilevNStas merge conflict here. also, this value will be shifted by renovate later, automatically. we should prohibit this in the |
|
Please fix the merge conflicts so this pull request can be merged. |
923641c to
61a6c58
Compare
|
@yegor256 plz re-review |
Description
codecov.ymluses Ruby 4.0.5 whilerake.yml(the primary CI workflow) uses Ruby 3.3. The gemspec requires>=3.3, meaning 3.3 is the minimum supported version.This drift means coverage is measured on a different Ruby version than the tests run on, which can lead to inconsistencies.
Fix
Changed
codecov.ymlRuby version from4.0.5to3.3to match therake.ymlCI matrix.Verification
yamllint— passesYAML.load_file— validCloses #480