#480: align codecov Ruby version with rake#486
Conversation
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed the workflow-only change against #480. The Codecov job now uses the same Ruby version as the rake matrix, and the regression parses both workflow files so future drift between codecov.yml and rake.yml fails in the test suite.
Validation I ran on 825f1b7b7096e96b43aa4a145e0ff70b32990cee:
env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle check-> dependencies satisfied.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec ruby -Itest test/test_workflows.rb -- --no-cov-> 1 run, 1 assertion, 0 failures, 0 errors.- origin/master mismatch repro ->
codecov="4.0.5", rake3.3. env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rake test-> 284 tests, 803 assertions, 0 failures, 0 errors, 9 skips.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rubocop test/test_workflows.rb --format simple-> 1 file inspected, no offenses detected.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- ruby -c test/test_workflows.rb-> Syntax OK.git diff --check origin/master...HEAD-> passed.git diff origin/master...HEAD | gitleaks stdin --no-banner --redact --exit-code 1-> no leaks found.
No changes requested.
|
@GHX5T-SOL Thanks for the review! 🎉 You've earned +6 points for this contribution. Here's the breakdown per our work policy: +18 as a basis, -8 for absolutely no comments posted (which deducts points when there are zero comments), and -4 for having fewer than 24 hits-of-code (you had 23). Your running score is +140 - keep up the great work and don't forget to check your Zerocracy account! |
|
@akmhatey-ai merge conflicts here |
|
Please fix the merge conflicts so this pull request can be merged. |
Fixes #480.
What changed:
Validation:
Limitation: