Skip to content

#480: align codecov Ruby version with rake#486

Open
akmhatey-ai wants to merge 2 commits into
zerocracy:masterfrom
akmhatey-ai:codex/align-codecov-ruby-480
Open

#480: align codecov Ruby version with rake#486
akmhatey-ai wants to merge 2 commits into
zerocracy:masterfrom
akmhatey-ai:codex/align-codecov-ruby-480

Conversation

@akmhatey-ai

Copy link
Copy Markdown
Contributor

Fixes #480.

What changed:

  • set the Codecov workflow's ruby/setup-ruby version to 3.3, matching the existing rake workflow matrix
  • add a small workflow regression test that keeps the Codecov Ruby version aligned with the rake matrix

Validation:

  • red: ruby test/test_workflows.rb failed before the workflow change with Expected: 3.3 / Actual: 4.0.5
  • green: ruby test/test_workflows.rb
  • git diff --check
  • gitleaks dir --no-banner --redact --exit-code 1 .

Limitation:

  • bundle exec rake test was attempted locally, but this Windows environment is missing locked gems after psych 5.3.1 failed to build because yaml.h is unavailable. The targeted workflow test above runs without Bundler and covers this change directly.

@GHX5T-SOL GHX5T-SOL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the workflow-only change against #480. The Codecov job now uses the same Ruby version as the rake matrix, and the regression parses both workflow files so future drift between codecov.yml and rake.yml fails in the test suite.

Validation I ran on 825f1b7b7096e96b43aa4a145e0ff70b32990cee:

  • env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle check -> dependencies satisfied.
  • env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec ruby -Itest test/test_workflows.rb -- --no-cov -> 1 run, 1 assertion, 0 failures, 0 errors.
  • origin/master mismatch repro -> codecov="4.0.5", rake 3.3.
  • env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rake test -> 284 tests, 803 assertions, 0 failures, 0 errors, 9 skips.
  • env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rubocop test/test_workflows.rb --format simple -> 1 file inspected, no offenses detected.
  • env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- ruby -c test/test_workflows.rb -> Syntax OK.
  • git diff --check origin/master...HEAD -> passed.
  • git diff origin/master...HEAD | gitleaks stdin --no-banner --redact --exit-code 1 -> no leaks found.

No changes requested.

@0crat

0crat commented May 26, 2026

Copy link
Copy Markdown

@GHX5T-SOL Thanks for the review! 🎉 You've earned +6 points for this contribution. Here's the breakdown per our work policy: +18 as a basis, -8 for absolutely no comments posted (which deducts points when there are zero comments), and -4 for having fewer than 24 hits-of-code (you had 23). Your running score is +140 - keep up the great work and don't forget to check your Zerocracy account!

@yegor256

Copy link
Copy Markdown
Member

@akmhatey-ai merge conflicts here

@yegor256

Copy link
Copy Markdown
Member

Please fix the merge conflicts so this pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Ruby version drifts between codecov.yml (4.0.5) and rake.yml (3.3)

4 participants