#479: add iterate since DSL#485
Conversation
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed the Fbe::Iterate#since DSL change against #479. The new setter matches the documented restart marker behavior, rejects nil/non-Integer/duplicate configuration, and the regression proves since(7) becomes the initial $before value used by the query.
Validation I ran on a82e147cd5a91d84a248a1f9894442822e9e0626:
env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle check-> dependencies satisfied.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec ruby -Itest test/fbe/test_iterate.rb -- --no-cov-> 29 tests, 59 assertions, 0 failures, 0 errors.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rake test-> 287 tests, 806 assertions, 0 failures, 0 errors, 9 skips.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rubocop lib/fbe/iterate.rb test/fbe/test_iterate.rb --format simple-> 2 files inspected, no offenses detected.env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- ruby -c lib/fbe/iterate.rband... -- ruby -c test/fbe/test_iterate.rb-> Syntax OK.git diff --check origin/master...HEAD-> passed.git diff origin/master...HEAD | gitleaks stdin --no-banner --redact --exit-code 1-> no leaks found.
No changes requested.
|
@GHX5T-SOL Great work on the review! 🎉 You've earned +10 points (+18 base, -8 for missing comments). Your total score is now +150. Check your Zerocracy account for updates! |
| # @example Start scanning after issue 100 | ||
| # iterator.since(100) | ||
| def since(value) | ||
| raise(Fbe::Error, 'Since is already set') if @custom |
|
This pull request has merge conflicts. Please rebase it on the default branch to resolve them so it can be merged. |
…-479 # Conflicts: # lib/fbe/iterate.rb
|
Merged current Conflict resolution:
Validation:
Limitation: hosted |
|
@akmhatey-ai rake fails here |
Closes #479.
Changes:
since(value)DSL setter toFbe::Iterate.sinceconfiguration.since(7)feeds the initial$beforevalue.Validation:
bundle exec ruby test\fbe\test_iterate.rb -- --no-cov --name test_configures_since_startfailed withNoMethodError: undefined method 'since' for an instance of Fbe::Iterate.bundle exec ruby test\fbe\test_iterate.rb -- --no-covpassed with29 tests, 59 assertions, 0 failures, 0 errors, 0 skips.bundle exec rubocop lib\fbe\iterate.rb test\fbe\test_iterate.rbpassed with no offenses.ruby -c lib\fbe\iterate.rbandruby -c test\fbe\test_iterate.rbpassed.git diff --checkpassed.git diff -- lib\fbe\iterate.rb test\fbe\test_iterate.rb | gitleaks stdin --no-banner --redactreported no leaks.Limitation:
bundle exec rake testis locally blocked on this Windows setup by unrelatedtyphoeus/ethonlibcurlloading while requiringtest_enter.rb, so local full-suite completion is not claimed.