#474: anchor repository mask regex#483
Open
akmhatey-ai wants to merge 1 commit into
Open
Conversation
GHX5T-SOL
approved these changes
May 26, 2026
GHX5T-SOL
left a comment
Contributor
There was a problem hiding this comment.
Verified the mask anchoring change for #474. Anchoring Fbe.mask_to_regex with \A/\z fixes prefix-collision rejects while preserving wildcard suffix matching.
Validation:
env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle check-> dependencies satisfiedenv BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec ruby -Itest test/fbe/test_unmask_repos.rb -- --no-cov-> 7 tests, 18 assertions, 0 failures, 0 errors, 1 skipenv BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rake test-> 285 tests, 812 assertions, 0 failures, 0 errors, 9 skipsenv BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rubocop lib/fbe/unmask_repos.rb test/fbe/test_unmask_repos.rb --format simple-> 2 files inspected, no offensesruby -c lib/fbe/unmask_repos.rbandruby -c test/fbe/test_unmask_repos.rb-> Syntax OKgit diff --check origin/master...HEAD-> passedgit diff origin/master...HEAD | gitleaks stdin --no-banner --redact --exit-code 1-> no leaks found
Live pre-review state: open, non-draft, mergeable/CLEAN, all GitHub checks green, no existing comments/reviews. Same-scope open PR search for #474 returned only this PR.
|
@GHX5T-SOL Great work on the review! 🎉 You've earned +6 points (+18 base, -8 for missing comments, -4 for low code coverage with 19 hits). Your total score is now +162 - keep up the momentum and check your Zerocracy account for updates! |
Member
|
@akmhatey-ai merge conflicts here |
Member
|
Please fix the merge conflicts so this pull request can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474.
What changed:
Fbe.mask_to_regexwith\Aand\zso masks must match the completeorg/repofull name.Validation:
bundle exec ruby test\fbe\test_unmask_repos.rb -- --no-covfailed on the new prefix-collision assertions.bundle exec ruby test\fbe\test_unmask_repos.rb -- --no-covpassed: 7 tests, 18 assertions, 0 failures, 0 errors, 1 skipped.bundle exec rubocop lib\fbe\unmask_repos.rb test\fbe\test_unmask_repos.rbpassed with no offenses.ruby -c lib\fbe\unmask_repos.rbandruby -c test\fbe\test_unmask_repos.rbpassed.git diff --checkpassed.git diff -- lib\fbe\unmask_repos.rb test\fbe\test_unmask_repos.rb | gitleaks stdin --no-banner --redactreported no leaks.Limitation:
bundle exec rake testis locally blocked on this Windows setup before reaching this patch area becausetyphoeus/ethoncannot loadlibcurlwhile loading unrelatedtest_enter.rb. I did not change that path.