docs(ws-bridged): example-yaml entspricht jetzt dem Parser-Schema - #4
Closed
SandraK82 wants to merge 1 commit into
Closed
docs(ws-bridged): example-yaml entspricht jetzt dem Parser-Schema#4SandraK82 wants to merge 1 commit into
SandraK82 wants to merge 1 commit into
Conversation
Die alte ws-bridged.yaml.example hatte verschachtelte Top-Level-Keys
(participant.domain_id, websocket.bind, routes, observability.metrics_bind)
die der echte YAML-Parser in daemon/config.rs nicht versteht — er erwartet
flache Keys (listen, domain) plus topics:/auth:/tls:/metrics:/acl:.
Da der Parser unbekannte Top-Level-Keys stillschweigend ignoriert
(load_from_str-Match: "_ => {}"), fällt die Fehlkonfig nicht durch
Validation-Errors auf. Bridge bootet mit Defaults (127.0.0.1:8080,
domain=0, topics=0, auth-mode=none).
Fix: example umgeschrieben gegen Spec §3 + Parser. Plus Erklär-Comments
für auth-mode, ACL (bei non-none-Auth Pflicht), und Hinweis auf das
silent-ignore-Verhalten.
Signed-off-by: Sandra Theresa Keßler <mail@sandra-kessler.net>
This was referenced May 15, 2026
Contributor
Author
SandraK82
added a commit
that referenced
this pull request
May 15, 2026
…tion (#5) Bundles fixes for two bugs plus two follow-ups, internal GitLab pipeline 1064 green (13/13), GitHub Actions green (Build+Test + no_std). - fix CLI merge: apply_cli_overrides() applies --topic/--auth-token/--tls/--metrics; previously only --listen/--domain/--log-level took effect. Includes 8 unit tests. - fix yaml.example: rewritten against the flat parser schema (listen/domain/log_level/tls/auth/acl/metrics/topics); spec ref corrected from §4 to §3. Plus include_str!-based loadback integration test so future doc-drift fails CI instead of booting with defaults in production. - parser drift-detection: load_from_str now emits a stderr WARN for unknown top-level keys (forward-compat preserved, drift visible). Unit test freezes the forward-compat semantics. Closes #1, closes #3. Supersedes #2, #4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
Summary
Die alte
packaging/linux/configs/ws-bridged.yaml.examplehatteverschachtelte Top-Level-Keys (
participant.domain_id,websocket.bind,routes:mitdds_topic:,observability.metrics_bind) — das echteParser-Schema in
daemon/config.rs::load_from_strerwartet flachlisten:,domain:,log_level:,tls:,auth:,acl:,metrics:,topics:.Parser ignoriert unbekannte Keys (
_ => {}), daher fiel die Drift nie auf:Bridge bootete mit Defaults statt User-Setting.
Changes
silent-ignore-Verhalten als Doku-Drift-Watchpoint.
Test Plan
crates/websocket-bridge/src/daemon/config.rs::load_from_strgelesen, jeder Key in der neuen example-yaml hat ein passendes
Match-Arm.
Follow-ups (separater PR, nicht in diesem Scope)
Parser sollte unbekannte Top-Level-Keys als WARN loggen, damit
zukünftige Doku-Drift sichtbar wird. Im Issue #3 als Follow-up
notiert.
DCO: Signed-off-by enthalten.