Repository navigation
fix(sdk): send DELETE request bodies and name nested keys on MCP params - #51
Merged
Merged
Conversation
DELETE operations with a requestBody dropped it, so removals such as remove_campaign_assets reached the API with no input (invalid_json_body). MCP params typed list[dict]/dict now list the keys each object takes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The hosted MCP could not remove Google Ads assets: generated DELETE methods dropped their request body, so the API answered
invalid_json_body. MCP params typedlist[dict](e.g.updates,campaigns) gave agents no keys to fill.What
generate_resources.py: DELETE operations with arequestBodybuild the payload and pass it asdata;_delete/_adeletesend it as JSON.generate_mcp_tools.py: object and array-of-object params list their keys (type, required, description, one level of nested keys) in the param description.generated_tools.pyfrom the committed spec; tests for both.Follow-ups
🤖 Generated with Claude Code