Conversation
…hell injection, path traversal) handle_logs and handle_job_get put a URL segment straight into a shell string. With the fleet token that was a whitelist bypass for /exec: a build of master answers /logs/x;id with 200 and runs the tail loop on it (8 of 11 checks in tools/fleet/check_ident.sh fail on master, 0 on this build). safe_ident allows [A-Za-z0-9_.-], refuses empty, over 64 chars and '..', with the primitives the agent already links. The 2026-08-28 binaries deployed on the three Macs already refused these, but from a source that is not on master; this makes the source and the binary agree. Suite 203/203. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018TygXw4GBESE8yTUipXWf4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_logs and handle_job_get put a URL segment straight into a shell string. With the fleet token that was a whitelist bypass for /exec: a build of master answers
/logs/x;idwith 200 and runs the tail loop on it.tools/fleet/check_ident.shdrives a live agent with raw metacharacters: 8 of 11 checks fail on master's build, 0 on this branch.safe_identallows[A-Za-z0-9_.-], refuses empty, over 64 chars and.., using only the primitives the agent already links (the stdlib string module is not part of the agent build). Suite 203/203.The 2026-08-28 binaries on the three Macs already refused these, from a source that is not on master; the fixed build is being deployed so source and binary agree.
🤖 Generated with Claude Code
https://claude.ai/code/session_018TygXw4GBESE8yTUipXWf4