Merged
Conversation
Mirrors watching_session_update but gives the frontend a clear "this is the final flush" semantic that we can grow side effects on later (e.g., flipping is_active if/when UserWatchingSession gains that flag, emitting analytics events, etc.) without touching the frontend. Today the body is identical to watching_session_update, because UserWatchingSession has no is_active column. The streak credit still flows correctly via update_activity_session, which routes through the session-language attribution added in #525. Companion to the frontend hooks refactor in zeeguu/web#1023, which introduces a useWatchingSession hook that calls api.endWatchingSession on cleanup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
ArchLens - No architecturally relevant changes to the existing views |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to zeeguu/web#1023, which introduces a
useWatchingSessionhook that callsapi.endWatchingSessionon cleanup.Summary
Adds a new
/watching_session_endendpoint that mirrorswatching_session_update. Today the body is functionally identical (UserWatchingSessionhas nois_activeflag, unlike listening/reading/exercise/browsing), so this is a +15-line addition with no schema change.The endpoint exists for symmetry with other session types and to give the frontend a clear "this is the final flush" semantic. We can grow side effects on it later (analytics, optional
is_activeif the model gains that column) without touching the frontend.The streak credit still flows correctly via
update_activity_session, which routes through the session-language attribution from #525.Test plan
/watching_session_end(200)🤖 Generated with Claude Code