Skip to content

fix(npm): mirror the binary's exit status instead of throwing a Node stack trace #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leechenghsiu merged 1 commit into from
Sep 6, 2026
Merged

fix(npm): mirror the binary's exit status instead of throwing a Node stack trace #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion npm/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,21 @@ function getArch() {
const pathToBinary = fileURLToPath(new URL(`./zeabur_${platform}_${arch}/zeabur${platform === "windows" ? ".exe" : ""}`, import.meta.url));
const args = process.argv.slice(2);

execFileSync(pathToBinary, args, { stdio: "inherit" });
// This wrapper must be transparent: the binary already wrote its own
// stdout/stderr (stdio: "inherit"), so on failure we only mirror its exit
// status. Letting execFileSync throw would print a Node stack trace with
// `stdout: null, stderr: null` and replace the real exit code with 1.
try {
execFileSync(pathToBinary, args, { stdio: "inherit" });
} catch (e) {
if (typeof e.status === "number") {
process.exit(e.status);
}
if (e.signal) {
// Shell convention for a process killed by a signal.
process.exit(128 + (os.constants.signals[e.signal] ?? 0));
}
console.error(e.message ?? String(e));
process.exit(1);
}
})()