Repository navigation
Named rules for every plugin - #3
Merged
Merged
Conversation
- failed commands handled by one rule per file, with per-subcommand rules where the failure view is not raw (go test, cargo test, npm audit) - single catch-all plugins become one flat rule per level - terraform: -json is truncated as JSON on every subcommand - bump converted plugins by one minor version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
ruleblocks, likekubectl-compactin kubectl: named rules (needs lowfat 0.9.0) #2.go test,cargo test,npm audit), a per-subcommand rule comes first.pytest,curl,psql,ansible) become one flat rule per level.terraform:-jsonis truncated as JSON on every subcommand. Before,init,validateandfmtignored the flag.Testing
terraformdiffers in 44 cases, allinit,validateorfmtwith-json, which is the change above.lowfat plugin benchnumbers are unchanged for every plugin.Merge order
Needs lowfat 0.9.0. It is on GitHub releases and Homebrew. crates.io still has 0.8.1 until the publish job is rerun.