Fix fill_value=null zarr v2 to v3 conversion for string dtypes#845
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
+ Coverage 88.99% 89.03% +0.04%
==========================================
Files 34 34
Lines 1945 1943 -2
==========================================
- Hits 1731 1730 -1
+ Misses 214 213 -1
🚀 New features to boost your workflow:
|
|
thanks for working on this, please feel welcome to ping whenever you need a review |
|
@maxrjones and others please have a look now. I am not sure if I did the casting correctly to fix the mypy error, but all is passing now. I have also tested that my test is failing with the previous version. |
maxrjones
left a comment
There was a problem hiding this comment.
Thanks @observingClouds
I think the other fix from #826 (comment) (if not np.issubdtype(self.dtype, dtype):) is also needed to close out #826. Do you want to include that fix in this PR?
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
|
Alright @maxrjones, I included now the fix mentioned in #826 (comment) and ensured with an additional test that this code is effective (failed without/succeeds with fix) I also had to do some mypy fix, which I believe is unrelated and originates from a mypy update. Let me know if I shall exclude this from this PR, otherwise I think this is good to go. |
Adds support to convert unset/
nullfill values from zarr format 2 metadata to format 3 for string types.docs/releases.rst- [ ] New functions/methods are listed inapi.rst- [ ] New functionality has documentation