Repository navigation
GH-50869: Generalize same-type constraint and expand coalesce tests - #84
Merged
zanmato1984 merged 3 commits intoSep 2, 2026
Merged
zanmato1984 merged 3 commits into
zanmato1984 merged 3 commits into
Conversation
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
|
❌ GitHub issue apache#50869 could not be retrieved. |
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
zanmato1984
merged commit Sep 2, 2026
f051dd3
into
codex/coalesce-exact-dispatch-decimal
65 of 76 checks passed
|
❌ GitHub issue apache#50869 could not be retrieved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AllTypesAreIdentical()andAllTypesAreIdenticalFrom(first_type_index)inkernel.h/kernel.cccase_when's private same-type constraint withAllTypesAreIdenticalFrom(1)AllTypesAreIdentical()for decimalcoalescekernelsdecimal256(4, 1)anddecimal128(3, 2)in both argument ordersThis is a reviewable follow-up for apache#50870. Merging this PR updates the head branch of that upstream PR.
Tests
arrow-compute-internals-test --gtest_filter='MatchConstraint.*'arrow-compute-expression-test --gtest_filter='Expression.BindWithImplicitCastsForCoalesceOnDecimal:Expression.ExecuteCoalesceOnMixedDecimalTypes'arrow-compute-scalar-if-else-test --gtest_filter='TestCoalesce.*:TestCaseWhen.*'