Skip to content

GH-50869: Generalize same-type constraint and expand coalesce tests - #84

Merged
zanmato1984 merged 3 commits into
codex/coalesce-exact-dispatch-decimalfrom
codex/coalesce-pitrou-review
Sep 2, 2026
Merged

zanmato1984 merged 3 commits into
codex/coalesce-exact-dispatch-decimalfrom
codex/coalesce-pitrou-review

Conversation

@zanmato1984

@zanmato1984 zanmato1984 commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • expose AllTypesAreIdentical() and AllTypesAreIdenticalFrom(first_type_index) in kernel.h / kernel.cc
  • replace case_when's private same-type constraint with AllTypesAreIdenticalFrom(1)
  • use AllTypesAreIdentical() for decimal coalesce kernels
  • add combined decimal width/scale regressions for decimal256(4, 1) and decimal128(3, 2) in both argument orders

This is a reviewable follow-up for apache#50870. Merging this PR updates the head branch of that upstream PR.

Tests

  • arrow-compute-internals-test --gtest_filter='MatchConstraint.*'
  • arrow-compute-expression-test --gtest_filter='Expression.BindWithImplicitCastsForCoalesceOnDecimal:Expression.ExecuteCoalesceOnMixedDecimalTypes'
  • arrow-compute-scalar-if-else-test --gtest_filter='TestCoalesce.*:TestCaseWhen.*'

Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

❌ GitHub issue apache#50869 could not be retrieved.

Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
@zanmato1984 zanmato1984 changed the title GH-50869: Address coalesce review feedback GH-50869: Generalize same-type constraint and expand coalesce tests Sep 2, 2026
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
@zanmato1984
zanmato1984 merged commit f051dd3 into codex/coalesce-exact-dispatch-decimal Sep 2, 2026
65 of 76 checks passed
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

❌ GitHub issue apache#50869 could not be retrieved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant