chore: link the tsup baseUrl workaround to its upstream issue/PR - #27
Merged
Conversation
The `ignoreDeprecations: "6.0"` line exists only because tsup's DTS build injects a default `baseUrl` (deprecated in TS 6, removed in TS 7). Reference the upstream tracking so we know when the workaround can go: egoist/tsup#1388, fixed by egoist/tsup#1390. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zanlucathiago
added a commit
that referenced
this pull request
Jul 13, 2026
The Release workflow runs on every push to main. On a merge with no pending changeset (Dependabot, docs, chore), changesets/action still ran `publish`, which tried to re-publish the current version. Since it's already on npm, changesets 2.31.0 crashed parsing npm's "already published" response instead of no-opping — red-X-ing every routine merge (e.g. run #27 from the #39 merge). Guard the step: only run changesets/action when a changeset is pending or the local version isn't the one published on npm. Routine merges now skip it; the real release paths (open the version PR / publish the bumped version) are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
ignoreDeprecations: "6.0"intsconfig.jsonis a workaround for tsup unconditionally injectingbaseUrl: "."into its DTS build (deprecated in TS 6, removed in TS 7).This just annotates the line with the upstream tracking so a future reader knows exactly when it can be removed:
Verified locally that PR #1390's one-line fix makes our DTS build pass on TypeScript 6.0.3 without
ignoreDeprecations, and left a tested confirmation on that PR. No code change here — comment only.🤖 Generated with Claude Code