switch to rbac/v1#829
Merged
Merged
Conversation
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
February 14, 2020 17:31
Contributor
Author
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: first change RBAC apiVersion, then enable namespaced roles
Deploying the operator with namespaced roles support (see #786) creates the
postgres-podrole in each namespace. If we want to bind to a clusterrole instead we must then overwrite the internal definition by setting thepod_service_account_role_binding_definitionin the configmap. So we should first configure the operator and then deploy.And here's the problem: When changing the RBAC version within the same PR, the apiVersion in the role definition must be of version
v1do be supported by the new operator. But the current operator only understandsv1beta1. Everything could be done in one go, but it's safer to do this step here first. Everyone using these definition options must switch tov1then, but they would need to do this anyway at some point.