Secrets deletion config#2582
Merged
Merged
Conversation
dmotte
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
macedigital and
sdudoladov
as code owners
March 15, 2024 13:51
FxKu
reviewed
Mar 27, 2024
Co-authored-by: Felix Kunde <felix-kunde@gmx.de>
Contributor
|
👍 |
Contributor
|
Thanks @dmotte |
|
@dmotte as far as I've understood this configuration is per operator. Is there a way to let the postgres cluster decide if it should keep the secret? |
Contributor
Author
|
@Yingrjimsch I think it can be implemented by adding a config option to the cluster manifest. To be honest I don't need it, but, if you want to give it a try, feel free to add me as a reviewer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a configuration option to provide a way to disable the deletion of Kubernetes secrets:
enable_secrets_deletion(defaulttrue).Ratio: see #1736 (comment)
I think many people would love this feature. This also relates to #2579, which otherwise wouldn't make much sense, because attaching already-existing volumes to a brand new cluster doesn't work due to different secrets.
Inspired by #2579 (huge thanks to @FxKu)