Repository navigation
chore(ontology): step 6 — gates - #605
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The observe-only `cgis-project` binding (pipeline_stage, never enforced) is replaced by what the language-packs migration built: the forbidden-edge gate with exact shrinking allowlists (test_architecture.py) as the enforced topology check, and the build/read plane quotients printed observe-only. The plane report now owns its binding (QUOTIENT_PREFIX) instead of borrowing the deleted one — same numbers (build 0.236, read 0.676). `project_level` stays a supported feature for other repositories; only this one stops using it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`extraction` (one domain over every pack) becomes languages.python and languages.typescript, both layered_dag at one shared tolerance, and core gets a domain. All three are new domains, set at their measurement plus headroom (main ca32430, fresh ingest of src/): | domain | layered_dag | best fit | unresolved | | languages.python | 0.393 | funnel 0.328 | 0.356 | | languages.typescript | 0.184 | layered_dag | 0.295 | | core | 0.215 | layered_dag (pure_utility 0.554) | 0.191 | Rulings (user-decided at plan review): G1 core is layered_dag 0.25, not the spec's pure_utility — since steps 1-4 the pack contract in core is layered. G2 the packs share 0.42, the loosest pack plus headroom, so a new pack faces the same bar; tests/unit/test_patterns_yaml.py fails for a registered pack with no domain or a different tolerance (both mutation-checked). The build plane's quotient now lists the packs: drift 0.236 -> 0.016, the pipeline-centred star. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fail Step 6's build-plane report read 0.016 against orchestrator — not an improvement but an artifact: `cgis.languages` (the registry) belongs to no drift domain, every build-plane edge into the languages area targets it, and the two pack nodes sat isolated in the quotient (final review, Important). The report now adds the registry as a plane-local node (longest-prefix match keeps the packs to their own domains) and fails when any plane node has no edge — the check that would have caught it. The build plane reads 0.351 (main 0.236, when `extraction` was one node): pipeline and resolver reach the packs only through the registry. Spec note corrected. Also pins core's layered_dag (ruling G1) in test_core_has_a_domain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements Step 6 of the Language Packs migration by retiring the observe-only 'project_level' quotient binding and introducing individual drift domains for each language pack ('languages.python', 'languages.typescript') and 'core'. It also updates the self-parsing tests to report plane quotients independently and adds test coverage to ensure all registered packs declare their domains at a shared tolerance. The review feedback highlights two type-safety issues: the 'DomainConfig' instantiation for 'languages' in 'test_drift.py' is missing required arguments ('profile' and 'drift_tolerance'), and a potential 'None' subscripting error in 'test_patterns_yaml.py' that would fail strict type-checking.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 6 of the language-packs migration (spec
docs/specs/2026-10-14-language-packs-design.md"Drift gates", plandocs/plans/2026-10-14-language-packs-step6.md, part of #146). Config and tests only — nosrc/change, so no graph can change.What changes
project_levelbinding is retired (patterns.yaml,tolerances.lock, its observe-only test). The enforced topology gate is the forbidden-edge test intest_architecture.pywith exact shrinking allowlists — after steps 1–5,surface-packs,engine-packsandresolver-storageare all empty.project_levelstays a supported feature for other repositories (CLI, MCPcgis_drift→quotient: [], guardian all handle an empty binding list; their own-YAML tests are unchanged and green).extractionbecomes one domain per pack,languages.pythonandlanguages.typescript, bothlayered_dagat one shared tolerance 0.42, plus acoredomain. A new test makes every registered pack (cgis.languages.MANIFESTS) declarelanguages.<name>at that tolerance and pattern — a Go pack arriving without one fails the suite and is named (mutation-checked).QUOTIENT_PREFIX) and now fails if a plane node has no edge.Measurements (main ca32430, fresh ingest of
src/; reviewer re-measured, identical)languages.pythonlanguages.typescriptcorelanguages.pythonandcorestart in the warning band — the headroom chosen below.Rulings (G1, G2 decided at plan review)
coreislayered_dag, not the spec'spure_utility: since steps 1–4 it holds the layered pack contract (0.215 vs 0.554).layered_dagat 0.42 — the loosest pack plus headroom — so a new pack faces the same bar.languages.python) work throughout (quotient ids, CLI, MCP, guardian) — no fallback needed.Correction from the final review
An earlier commit on this branch (4a7100b) reported the build plane improving 0.236 → 0.016. That was an artifact: the registry
cgis.languagesbelongs to no drift domain, every build-plane edge into the languages area targets it, and the two pack nodes sat isolated. Fixed in f2a53a5: the report adds the registry as a plane-local node and fails on isolated plane nodes. The build plane reads 0.351 againstorchestrator(main 0.236, withextractionas one node) — pipeline and resolver reach the packs only through the registry. Observe-only; the spec note says so.Deferred
Closes the design work of #146 in prose only — I will close #146 by hand after merge with a summary of steps 0–6 (step 7, the Go pilot, does not block it).
Gate: format, lint, mypy strict, 3232 passed, docstring 99%.
🤖 Generated with Claude Code