This PR modernizes the Hydro-Without-Hydro Start-to-Finish Notebook#85
Open
leowerneck wants to merge 1 commit intomasterfrom
Open
This PR modernizes the Hydro-Without-Hydro Start-to-Finish Notebook#85leowerneck wants to merge 1 commit intomasterfrom
leowerneck wants to merge 1 commit intomasterfrom
Conversation
- diagnostics_generic/output_yz_or_xy_plane.py: extended plane diagnostics
function to accept a file pointer;
- Tutorial-Start_to_Finish-BSSNCurvilinear-TOV_Initial_Data.ipynb: modified to
reflect the first change;
- Tutorial-Start_to_Finish-BSSNCurvilinear-Exact_Initial_Data.ipynb: modified
to reflect the first change;
- Tutorial-Start_to_Finish-BSSNCurvilinear-Neutron_Star-Hydro_without_Hydro.ipynb:
minor modernizations to the main function; notebook now works in coordinates
other than Spherical-like.
leowerneck
changed the title
Owner
|
Thanks for the PR @leowerneck . Please be sure to address all the issues that GitHub Actions found. |
|
Just a heads up, you can review notebook changes like this using GitNotebooks. e.g. this pull request https://gitnotebooks.com/zachetienne/nrpytutorial/pull/85 It's free for public repos, so might be helpful for y'all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates: