feat(comments): --all flag to fetch every comment page - #7
Open
Millon15 wants to merge 1 commit into
Open
Conversation
`bbkt prs comments list` returns a single page (default 50), silently dropping later comments on busy PRs. Add --all, which follows the paginated next cursor and merges all pages into one result via the new ListAllPRComments client method. Existing page/pagelen flags unchanged. Covered by a two-page VCR fixture asserting the merge.
Millon15
added a commit
to Millon15/bbkt
that referenced
this pull request
Jun 25, 2026
…-snell#6 x zach-snell#7 integration) Combining the resolution-aware list (zach-snell#6) with --all paging (zach-snell#7): ListAllPRComments routes every page through ListPRComments, which appends `&fields=%2Bvalues.resolution.user.display_name`. The list_comments_paged cassette was recorded before zach-snell#6, so its request URLs lacked that param and the exact-URL VCR matcher (matchMethodAndURL) missed. Add the param to both recorded request URLs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bbkt prs comments listreturns a single page (default 50), silently dropping later comments on busy PRs.Fix
Add
--all, which follows the paginatednextcursor and merges every page into one result (newListAllPRCommentsclient method). Existingpage/pagelenflags are unchanged.Verification
TestListAllPRComments_WalksPagesuses a two-page VCR cassette and asserts the merge.go test ./...green.