fix(comments,pipelines): send {} body so resolve/stopPipeline don't 400 - #5
Open
Millon15 wants to merge 1 commit into
Open
fix(comments,pipelines): send {} body so resolve/stopPipeline don't 400#5Millon15 wants to merge 1 commit into
Millon15 wants to merge 1 commit into
Conversation
Bitbucket rejects an empty request body sent with Content-Type:
application/json (HTTP 400). ResolvePRComment and StopPipeline posted a
nil body; the approve/decline actions already send an empty JSON object
{}. Align resolve/stopPipeline with that convention.
Adds a regression test asserting resolve POSTs {} with a JSON content type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bbkt prs comments resolvealways fails withAPI error 400: Bad Request, so comment threads cannot be resolved from the CLI (or the MCPresolvetool) — you have to open the browser.Cause
ResolvePRComment(andStopPipeline) POST a nil body. The client then sendsContent-Type: application/jsonwith an empty body, which Bitbucket rejects with 400. Theapprove/declineactions already send an empty JSON object{}and work fine.Fix
Send
map[string]interface{}{}({}) fromResolvePRCommentandStopPipeline, matching the existing approve/decline body-less-action convention.Verification
TestResolvePRComment_SendsEmptyJSONBodyasserts the resolve POST body is{}with a JSON content type.API error 400; patched build →Comment thread N resolved successfully.go test ./...green.