Repository navigation
Conversation
test-matrix.yml pinned docker/setup-buildx-action to 4d04d5d2235566ea9c44d6d2594696e5d0117bbb, which does not exist upstream (GitHub returns 422). The v4.0.0 tag resolves to 4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd; the two share only the 7-character prefix. pinact flags the bad pin, which keeps the weekly Trunk run on main red. Refs #28
ss-o
commented
Sep 26, 2026
ss-o
left a comment
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 39e22e0
A Copilot review was requested three ways on this head (gh pr edit --add-reviewer @copilot, GraphQL requestReviewsByLogin with copilot-pull-request-reviewer, and earlier REST on sibling PRs). None produced a review_requested event. zunit is class 2, so the fallback applies.
Reviewed under .github/skills/code-review/SKILL.md against code-review-generic.instructions.md (CI checks: immutable pins, permissions, side effects).
Findings: none.
- The diff changes one line in
.github/workflows/test-matrix.yml.docker/setup-buildx-actionmoves from4d04d5d2235566ea9c44d6d2594696e5d0117bbb(GitHub returns 422: no such commit) to4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd, which is whatrepos/docker/setup-buildx-action/commits/v4.0.0resolves to. The# v4.0.0comment now matches the SHA. - No permission, trigger or job change.
- Evidence: pinact 4.1.1
run --checkis clean on every workflow; Trunk (pinact, actionlint, yamllint, prettier) reports no issues; all 8 required and policy checks pass on this head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
test-matrix.ymlpinneddocker/setup-buildx-actionto4d04d5d2235566ea9c44d6d2594696e5d0117bbb, a commit that does not exist upstream (GET /repos/docker/setup-buildx-action/commits/<sha>returns 422). Thev4.0.0tag resolves to4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd; the two share only the 7-character prefix. This keeps the weekly Trunk run onmainred through pinact.The same one-line fix already sat on the unmerged branch
fix/codex-compatibility(ff40bb3, from 2026-09-11). That branch also carries an unrelated code-review skill and atrunk-check.ymlpin-comment change that the.pinact.yamlfrom #27 has since made unnecessary, so this PR takes only the pin fix. That branch is left untouched.Validation:
pinact run --check(4.1.1, with the repository.pinact.yaml) is clean on every workflow.trunk check --filter=pinact,actionlint,yamllint,prettier .github/workflows/test-matrix.yml: no issues.actionlint .github/workflows/test-matrix.yml: clean.