Repository navigation
docs(agents): align the branch-name rule with commit-lint - #160
Merged
Merged
Conversation
Closes #159. The rule listed only feature, bug and hotfix issue branches, while the commit-lint caller enforces the organization pattern, which also accepts an optional slug and <type>/<slug>; the text now links the pull-request runbook.
ss-o
commented
Oct 19, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 4c9d65f
Findings
No actionable findings.
Scope: the full diff of this head (AGENTS.md), closes #159.
Note
The maintainer elected this fallback after the Copilot request did not register (no review_requested event). It is a self-review by the authoring agent, not an independent review or approval to merge.
Validation
- Passed: PR checks on this head: 1 skipped, 23 success. Locally: Trunk markdownlint and prettier on the changed file; the commit hooks passed.
- Claims checked at source:
.github/workflows/commit-lint.ymlhere callsz-shell/.github/.github/workflows/commit-lint.ymlwith nobranch-patterninput, and the reusable workflow's default acceptsfeature|bug|hotfix-<issue>with an optional slug and<type>/<slug>; the runbook anchor#1-before-the-branchmatches its "1. Before the branch" heading.
Checklist verdicts and supporting evidence
- Documentation accuracy: pass. The new text states the enforced pattern and links its owner instead of a narrower list.
- Scope: pass. One line in
AGENTS.md; no code, workflow or behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #159.
AGENTS.mdlisted onlyfeature,bugandhotfixissue branches, but this repository'scommit-lint.ymlcalls the organization workflow with its defaultBRANCH_PATTERN, which also accepts an optional-<slug>and<type>/<slug>. The rule now states the enforced pattern and links the pull-request runbook.Verification
z-shell/.github/.github/workflows/commit-lint.ymlwith nobranch-patterninput; the default there accepts both forms.Agent handoff
No handoff needed.