Repository navigation
docs(agents): fold the Copilot adapter into AGENTS.md and bump org routing - #151
Merged
Merged
Conversation
…uting Fold the project guidance from .github/copilot-instructions.md into AGENTS.md (architecture, module invariants, test runs, optional tool integrations) and remove the adapter; AGENTS.md is the instruction entry point. Bump the Org Routing pin to the organization revision that drops the adapter surface and regenerate the routing block. Refs z-shell/.github#717, z-shell/.github#720
ss-o
commented
Oct 6, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on d684e17
Findings
No actionable findings.
Scope: the complete diff of d684e17d against base main at 7324c327 (merge base), 3 files, +34/-81. Specification: z-shell/.github#720 and the project adapter rule in the organization runbooks/new-repository.md at a9e78eb6.
Note
This is a maintainer-elected fallback self-review after the Copilot request did not register. It is not an independent review or approval to merge.
Review request record
- 2026-10-06T09:33:37Z:
POST /repos/z-shell/zpmod/pulls/151/requested_reviewerswithcopilot-pull-request-reviewer[bot]on head d684e17 returned success with an emptyrequested_reviewerslist. - No Copilot review request or review exists on the pull request. This pull request is not a draft. Review request not registered; cause unconfirmed.
Validation
- Passed, hosted on this head: Analyze (actions), Analyze (c-cpp), Analyze (python), Build docs (container), Controlled Digest Consistency, Docker Tests (full-dev), Docker Tests (minimal), Native Tests (macos-latest), Native Tests (ubuntu-latest), Native macos-latest 5.8.1, Native macos-latest 5.9.2, Native ubuntu-latest 5.8.1, Native ubuntu-latest 5.9.2, Org Routing / Org Routing, Package DEB, Package RPM, Policy / Validate Branch Name, Policy / Validate Commits, Policy / Validate Issue Link, Policy / Validate PR Title, Smoke Tests, Trunk Code Quality / Trunk Code Quality. Skipped by their own conditions: CodeQL, Deploy to Pages.
- Passed, local on this head:
org-routing.py checkfrom z-shell/.github ata9e78eb6(routing current),trunk checkon the changed files, a search for references to the removed path. - Signature: the commit is signed and GitHub reports it verified.
Checklist verdicts and supporting evidence
- Pin: pass.
.github/workflows/org-routing.ymlnow calls the organization workflow at the full commita9e78eb617a60f92716abd831d4cf414f332a585, the merge that drops the adapter surface for this repository. - Routing block: pass. Regenerated by
org-routing.py apply; only generated lines changed and the check reports it current. - Fold: pass. Each project fact from the removed file is in
AGENTS.mdand was checked against the tree (zp_conv_opt, the module hooks insrc/module/module.c,zallocandzsfree, the vendored headers and stubs,ZPMOD_VERSION_STR,zpmod_smoke,ZPMOD_STAGE_MODULE_DIR, the documentation folders). Dropped items no longer match the repository (VS Code task names without a.vscode/tasks.json, the ztst framework) or are runtime usage tips; the integration link moves to the organization's current tool integration instruction. - Markdown: pass. New lines are wrapped for the repository's MD013 setting;
trunk checkreports no issues. - Security: not applicable. Instruction files and a workflow pin to a reviewed organization commit.
Limits and follow-up
- Any push to this branch voids this review.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/copilot-instructions.mdintoAGENTS.mdand remove the adapter:AGENTS.mdis this repository's instruction entry point, and Copilot code review and the Copilot cloud agent read it natively.AGENTS.mdgains an Architecture section (source layers and module invariants: static builtin registration, thesetup_/finish_overrides, Zsh allocators, thezp_conv_optoption mapping, vendored headers and stubs, CMake version strings), the smoke and full test runs with theZPMOD_STAGE_MODULE_DIRtest convention, and the optional tool integration note..vscode/tasks.json), the ztst framework (tests are plain Zsh scripts run by CTest), and runtime tool-usage tips that are not project guidance. The integration link now points at the organization's current tool integration instruction;src/builtins/is added to the layer list.a9e78eb6, which no longer declares the adapter for this repository, and regenerate the routing block: the adapter line is gone, the rest of the block is unchanged.Refs z-shell/.github#717 and z-shell/.github#720.
Verification
AGENTS.mdwas checked against the tree:zp_conv_optinsrc/include/zpmod_compat.handsrc/compat/options.c,setup_,features_,enables_andfinish_insrc/module/module.c,zallocandzsfreeinsrc/builtins/zpmod_builtin.c, thezpmod_smoketest andZPMOD_STAGE_MODULE_DIRintests/CMakeLists.txt.org-routing.py checkfrom z-shell/.github ata9e78eb6reports the routing as current.trunk checkon the changed files reports no issues.Agent handoff