Skip to content

docs(agents): fold the Copilot adapter into AGENTS.md and bump org routing - #151

Merged
ss-o merged 1 commit into
mainfrom
chore/720-agents-md-only
Oct 6, 2026
Merged

ss-o merged 1 commit into
mainfrom
chore/720-agents-md-only

Conversation

@ss-o

@ss-o ss-o commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Fold the project guidance from .github/copilot-instructions.md into AGENTS.md and remove the adapter: AGENTS.md is this repository's instruction entry point, and Copilot code review and the Copilot cloud agent read it natively.
  • AGENTS.md gains an Architecture section (source layers and module invariants: static builtin registration, the setup_/finish_ overrides, Zsh allocators, the zp_conv_opt option mapping, vendored headers and stubs, CMake version strings), the smoke and full test runs with the ZPMOD_STAGE_MODULE_DIR test convention, and the optional tool integration note.
  • Left out because they no longer match the repository: the VS Code task names (there is no .vscode/tasks.json), the ztst framework (tests are plain Zsh scripts run by CTest), and runtime tool-usage tips that are not project guidance. The integration link now points at the organization's current tool integration instruction; src/builtins/ is added to the layer list.
  • Bump the Org Routing workflow pin to z-shell/.github a9e78eb6, which no longer declares the adapter for this repository, and regenerate the routing block: the adapter line is gone, the rest of the block is unchanged.

Refs z-shell/.github#717 and z-shell/.github#720.

Verification

  • Every path, symbol and test name moved into AGENTS.md was checked against the tree: zp_conv_opt in src/include/zpmod_compat.h and src/compat/options.c, setup_, features_, enables_ and finish_ in src/module/module.c, zalloc and zsfree in src/builtins/zpmod_builtin.c, the zpmod_smoke test and ZPMOD_STAGE_MODULE_DIR in tests/CMakeLists.txt.
  • org-routing.py check from z-shell/.github at a9e78eb6 reports the routing as current.
  • No tracked file refers to the removed path.
  • trunk check on the changed files reports no issues.

Agent handoff

…uting

Fold the project guidance from .github/copilot-instructions.md into AGENTS.md (architecture, module invariants, test runs, optional tool integrations) and remove the adapter; AGENTS.md is the instruction entry point. Bump the Org Routing pin to the organization revision that drops the adapter surface and regenerate the routing block.

Refs z-shell/.github#717, z-shell/.github#720

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on d684e17

Findings

No actionable findings.

Scope: the complete diff of d684e17d against base main at 7324c327 (merge base), 3 files, +34/-81. Specification: z-shell/.github#720 and the project adapter rule in the organization runbooks/new-repository.md at a9e78eb6.

Note

This is a maintainer-elected fallback self-review after the Copilot request did not register. It is not an independent review or approval to merge.

Review request record

  • 2026-10-06T09:33:37Z: POST /repos/z-shell/zpmod/pulls/151/requested_reviewers with copilot-pull-request-reviewer[bot] on head d684e17 returned success with an empty requested_reviewers list.
  • No Copilot review request or review exists on the pull request. This pull request is not a draft. Review request not registered; cause unconfirmed.

Validation

  • Passed, hosted on this head: Analyze (actions), Analyze (c-cpp), Analyze (python), Build docs (container), Controlled Digest Consistency, Docker Tests (full-dev), Docker Tests (minimal), Native Tests (macos-latest), Native Tests (ubuntu-latest), Native macos-latest 5.8.1, Native macos-latest 5.9.2, Native ubuntu-latest 5.8.1, Native ubuntu-latest 5.9.2, Org Routing / Org Routing, Package DEB, Package RPM, Policy / Validate Branch Name, Policy / Validate Commits, Policy / Validate Issue Link, Policy / Validate PR Title, Smoke Tests, Trunk Code Quality / Trunk Code Quality. Skipped by their own conditions: CodeQL, Deploy to Pages.
  • Passed, local on this head: org-routing.py check from z-shell/.github at a9e78eb6 (routing current), trunk check on the changed files, a search for references to the removed path.
  • Signature: the commit is signed and GitHub reports it verified.
Checklist verdicts and supporting evidence
  • Pin: pass. .github/workflows/org-routing.yml now calls the organization workflow at the full commit a9e78eb617a60f92716abd831d4cf414f332a585, the merge that drops the adapter surface for this repository.
  • Routing block: pass. Regenerated by org-routing.py apply; only generated lines changed and the check reports it current.
  • Fold: pass. Each project fact from the removed file is in AGENTS.md and was checked against the tree (zp_conv_opt, the module hooks in src/module/module.c, zalloc and zsfree, the vendored headers and stubs, ZPMOD_VERSION_STR, zpmod_smoke, ZPMOD_STAGE_MODULE_DIR, the documentation folders). Dropped items no longer match the repository (VS Code task names without a .vscode/tasks.json, the ztst framework) or are runtime usage tips; the integration link moves to the organization's current tool integration instruction.
  • Markdown: pass. New lines are wrapped for the repository's MD013 setting; trunk check reports no issues.
  • Security: not applicable. Instruction files and a workflow pin to a reviewed organization commit.

Limits and follow-up

  • Any push to this branch voids this review.

@ss-o
ss-o merged commit 96529da into main Oct 6, 2026
24 checks passed
@ss-o
ss-o deleted the chore/720-agents-md-only branch October 6, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant