Repository navigation
ci(lint): pin zsh-lint v1.4.0 and migrate the config to schema v2 - #137
Merged
Merged
Conversation
Part of z-shell/zsh-lint#612: move this repository to the released zsh-lint v1.4.0.
ss-o
commented
Oct 10, 2026
ss-o
left a comment
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Self-review of record on e626afc.
Read the full diff; it matches the description. The verification listed in the description ran locally against this exact diff with a zsh-lint binary built from the v1.4.0 tag. actionlint passes on every changed workflow.
No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Zsh lint job from the unreleased zsh-lint commit
1e8b0a6to the v1.4.0 release, and migrateszsh-lint.jsonto schema version 2, which v1.3.0 and later require (the current schema-1 file fails configuration validation). The v2 file keeps thetoolkind,minimum_zsh 5.5.1, and thedockerroot with thetest-fixtureprofile, and adds the requiredidentifier: zd. The emptyfunction_namespaceslist is no longer part of the schema.Part of z-shell/zsh-lint#612. zsh-lint v1.4.0: https://github.com/z-shell/zsh-lint/releases/tag/v1.4.0 (signed tag on
aff6018). Building it needs Go 1.26, so the Go version now comes from the analyzer's owngo.modinstead of a hardcoded"1.25".v1.4.0 behavior that can show up here:
quoting/unquoted-varis now Info and reports only standalone expansions, and rules now seebuiltin/command-prefixed commands (for examplebuiltin eval).Local check on this diff: v1.4.0 with
--config zsh-lint.jsonover the workflow targets (docker/utils.zsh,docker/zshrc,docker/zshenv) exits 0 with no findings.