Repository navigation
ci: retire obsolete sync-labels caller - #5
Conversation
Remove the dormant caller of the missing shared workflow. Preserve the remaining Trunk workflow and package metadata. Refs #4
|
Project 28 triage: filled Item Type The removal contract and full pinned Trunk check passed. All three hosted checks are green on |
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on f5794de
No actionable defects introduced by this change.
The complete diff deletes only the 12-line .github/workflows/sync-labels.yml caller from base 4e5d14bd56d3a33cd52f7e5127bd92d84e7ede57. The review request did not register; its cause remains unconfirmed.
Checklist and verification
- Correctness and scope: passed. The removed file contains only a Tuesday 02:22 UTC schedule, manual dispatch and one reusable job targeting the absent shared workflow. The removal contract failed on the base and passes on this head, proving caller absence and byte identity of all 12 retained tracked files.
- Security and state integrity: passed for the delta. No executable code, permissions, dependencies or secret handling is added. The retained Trunk workflow, package profiles, labels and settings are outside the deletion and preserved.
- Workflow checks: passed. Actionlint 1.7.12 and
git diff --checkpassed on the reviewed head. Repository-pinned Trunk 0.13.0-beta passed its full check in an isolated archive copy, with verbose coverage from actionlint, gitleaks, markdownlint and prettier. Hosted Trunk and CodeQL also passed on this head. - Traceability: passed. This change satisfies the removal scope of #4 and references z-shell/.github#472 without closing that coordinated work. The final acceptance step is verification of the merged main tree before another repository proceeds.
- Compatibility and application tests: no application code changes; the repository contains package metadata and no functional test suite. Source, interface and loading behavior remain unchanged.
- Recovery: the base caller is retained as blob
b9b9843c5af99539537e3f23ec3ddaf974b4ac76; a reviewed revert can restore its exact bytes, including the obsolete reference.
Limits and follow-up
This is a self-review under the written checklist, not an independent human approval or permission to merge. GitHub desktop and narrow-width rendering could not be inspected.
The unchanged .github/workflows/trunk-check.yml:26 still references mutable trunk.yml@main, contrary to the full-SHA policy. A separate fzy maintenance issue is proposed for a verified immutable pin; changing it here would violate #4's preservation scope. Local instruction and review-skill delivery is also absent and needs a separately scoped adoption proposal. This narrow review is not a clean repository-health assessment.
Summary
Remove only
.github/workflows/sync-labels.yml, the dormant caller of the missingz-shell/.github/.github/workflows/sync-labels.yml@maintarget. This is the fzy canary for z-shell/.github#472. The remaining Trunk workflow, package metadata and every other tracked file are unchanged.Closes #4. Refs z-shell/.github#472; the cross-repository removal remains unfinished.
Verification
4e5d14bd56d3a33cd52f7e5127bd92d84e7ede57.git diff --checkpassed.check --all --ci --no-progress --verbosein an isolated archive copy. Its output confirms actionlint, gitleaks, markdownlint and prettier coverage.Agent handoff
Merged in
d15e979d1cc2be9df92035c061b416db7e814b92. Main was verified to lack the caller, with all 12 retained file blobs and modes unchanged. Issue #4 is closed and both records are Done in Project 28. Rollback is a reviewed revert restoring caller blobb9b9843c5af99539537e3f23ec3ddaf974b4ac76.