Repository navigation
decision: amend ADR-0026 for maintainer-elected fallback reviews #664
Description
Problem
ADR-0026 (decision 3) allows the fallback review only after a Copilot request "is not registered", and makes the opening line Fallback review under ADR-0026: Copilot request not registered on <sha> part of that procedure. It does not cover a maintainer choosing the fallback up front to save review allowance.
On 2026-09-26 the maintainer chose exactly that for the commit-lint caller wave: fallback reviews on the ten class 2-4 pull requests, a Copilot request only on the two class 1 ones. No Copilot request was made on the ten, but each review opens with the ADR marker, so the record on these pull requests says a request failed when none was made:
z-shell/F-Sy-H#192, z-shell/z-a-default-ice#12, z-shell/z-a-eval#11, z-shell/z-a-meta-plugins#102, z-shell/zd#125, z-shell/zpmod#114, z-shell/zsh#23, z-shell/zsh-eza#125, z-shell/zsh-fancy-completions#68, z-shell/zunit#27.
Each now carries a correction comment.
A second gap showed up at the same time. Decision 3 treats every unregistered request as "blocked on quota". On z-shell/wiki#926 and z-shell/src#228, POST requested_reviewers with copilot-pull-request-reviewer[bot] returned 201, and no review_requested event followed. Quota exhaustion is one explanation, but an API or reviewer-identifier problem looks identical, and the ADR gives no way to tell them apart.
Proposal
- Add a maintainer-elected fallback for classes 2-4 with its own marker line, for example
Fallback review under ADR-0026: maintainer elected, no Copilot request on <sha>. - In decision 3, state how to confirm quota before declaring it: the request path that is known to register, and what the requester's allowance page shows.
- Say whether the ten reviews above should be amended in place or left with their correction comments.
Relates to #642.
Activity
ss-o commentedon Sep 26, 2026
Evidence from 2026-09-26 on z-shell/zsh-lint, relevant to how the fallback is recorded as well as when it is elected.
Fallback review under ADR-0026: Copilot request not registered on <sha>, after a real Copilot request that returned an empty reviewer list. The marker was accurate..github/skills/code-review/SKILL.mdagainstcode-review-generic.instructions.md, as ADR-0026 decision 3 requires. Each was the agent's summary of its own verification, with no inline threads. The skill was never loaded in that session.6789946at 16:39:42Z. The branch was force-pushed (a rebase) at 16:40:07Z, and the pull request was squash-merged one0d04ceat 16:42:32Z without a new review.--match-head-commitguarded the merge against a race, not against a stale review.If the amendment here touches the procedure, two points would close these gaps: the marker line should be accompanied by evidence that the checklist ran (for example the checklist items with a verdict each), and any push after the fallback review voids it.
ss-o commentedon Sep 26, 2026
Maintainer decision (ss-o, 2026-09-26): allow the fallback to be elected up front, with a distinct marker.
Fallback review under ADR-0026: maintainer elected, no Copilot request on <sha>. The existingCopilot request not registered on <sha>marker stays for the case where a request was made and did not register..github/skills/code-review/SKILL.mdagainstcode-review-generic.instructions.mdon the current head and posted with inline threads. A marker line alone is not a review.This will be written into the ADR-0026 amendment and into the pull-request runbook proposed under #668.
docs(runbooks): align PR runbook review steps with ADR-0026 (#668)
ss-o commentedon Sep 26, 2026
Maintainer decision (ss-o, 2026-09-26): the review of record where Copilot code review is not configured.
Fallback review under ADR-0026: maintainer elected, no Copilot request on <sha>.mainand z-shell/zinexthave nocopilot_code_reviewrule.This goes into the ADR-0026 amendment together with the up-front election decided above, and into the
AGENTS.mddone gate, which today speaks only of "every configured review". The pull-request runbook in #670 cites it as an interim rule until then.docs(runbooks): require a fresh Copilot event and cite the #664 rulin…
docs(runbooks): scope the Copilot check to the base branch (#668)
docs(runbooks): add a pull-request runbook (#668) (#670)
docs(review): codify maintainer-elected fallback reviews (#664) (#677)
ss-o commentedon Sep 27, 2026
Resolved by PR #677 (commit eee964a). ADR-0026, AGENTS.md, and runbooks/pull-requests.md codified the maintainer-elected fallback review for classes 2-4 under marker Fallback review under ADR-0026: maintainer elected, no Copilot request on .