perf(tsdb): add targeted label cardinality scan - #4
Open
yuchen-db wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yuchen Wang <yuchen.wang@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemPostings.Statsscans every label name and value while holdingRLock, even when a caller only needs the highest-cardinality values for one label such as__name__. Periodic callers can therefore block new-series insertion on large postings indexes.This adds
TopLabelValuesBySeriesCountonMemPostingsandHead. The method snapshots only the requested label's values and postings lengths underRLock, then performs top-K selection after releasing the lock. ExistingStatsand/api/v1/status/tsdbbehavior remain unchanged; Thanos must switch its periodic top-metrics collector to the new API in a follow-up.Benchmark
The fixture contains approximately 1,000
__name__values and 200,000 unrelated label values.Command:
Tests
go test ./tsdb/index ./tsdbgo test -race ./tsdb/index ./tsdb -run '^(TestMemPostingsTopLabelValuesBySeriesCount|TestHeadTopLabelValuesBySeriesCount)$' -count=1make lintwith the repository-selected Go 1.23 toolchain