git.rb: Fast exit from update_cache if repo not changed since cached - #3895
Open
zaits07 wants to merge 1 commit into
Open
git.rb: Fast exit from update_cache if repo not changed since cached#3895zaits07 wants to merge 1 commit into
zaits07 wants to merge 1 commit into
Conversation
Fast exit from update_cache if repo not changed since cached.
I need last change date in oxidized-web node list.
I patched oxidize-web and see last change date in node list according to last version from git repo date.
But my list of 200 nodes refreshes by 30 sec.
I found that almost time spent in git.update_cache.
Specifically in code
` walker = Rugged::Walker.new(repo)
walker.sorting(Rugged::SORT_DATE)
walker.push(repo.head.target.oid)`
And it called on every node, regardless that i have only one repo and it cached after first node.
zaits07
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Fast exit from update_cache if repo not changed since cached.
I need last change date in oxidized-web node list. I patched oxidize-web and see last change date in node list according to last version from git repo date. But my list of 200 nodes refreshes by 30 sec.
I found that almost time spent in git.update_cache. Specifically in code
walker = Rugged::Walker.new(repo)walker.sorting(Rugged::SORT_DATE)walker.push(repo.head.target.oid)take 150 ms.
And it called on every node, regardless that i have only one repo and it cached after first node.
200 nodes * 150 ms = 30 sec
Related to pr yttimiz/oxidized-web#461