model/fastiron: answer pager prompt and strip ANSI escape sequences - #3886
Open
FusionBrah wants to merge 1 commit into
Open
model/fastiron: answer pager prompt and strip ANSI escape sequences#3886FusionBrah wants to merge 1 commit into
FusionBrah wants to merge 1 commit into
Conversation
Collaborator
|
Should we wait for a reaction of @cr-bruderer ? |
The pager cannot always be disabled with 'skip-page-display', for example when the user has no enable rights. Answer the pager prompt with a space and strip the ANSI escape sequences used to redraw the screen. Fixes ytti#3819
FusionBrah
force-pushed
the
3819-fastiron-pager
branch
from
August 18, 2026 11:03
0456c57 to
28e9a5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
On Ruckus ICX devices, the pager cannot always be disabled with
skip-page-display, for example when the user has no enable rights. This adds twoexpectblocks to the fastiron model, as proposed and tested by @cr-bruderer in #3819: answer the pager prompt with a space and strip the ANSI escape sequences the pager uses to redraw the screen. The existingskip-page-displaypost_login is kept, as it still works for users with sufficient rights.Tests:
pass_with_expectprompt tests with ANSI-prefixed promptsskip-page-displayis rejected andshow running-configis interrupted by a--More--pager promptNote: the simulation is hand-built, not captured from a real device with device2yaml, as I have no access to an affected device. I will ask the reporter to test this branch on real hardware.
Fixes #3819