eos: hide secret in snmp-server host lines - #3885
Merged
robertcheramy merged 2 commits intoAug 15, 2026
Merged
Conversation
The secret filter only handled "snmp-server community", so the community string (v1/v2c) or user (v3) in "snmp-server host" lines was written to backups in cleartext. Add a filter modeled on ios.rb that masks the trailing credential token. Add minimal simulation, output and secret test data for a DCS-7050SX3-48YC8 on EOS 4.29.2F. Fixes ytti#3882
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3882.
The eos secret filter only handled
snmp-server community, sosnmp-server hostlines kept their community string (v1/v2c) or user (v3) in cleartext:This adds a filter modeled on the ios model:
Handles optional
vrf,traps/informsandversion 1|2c|3 noauth|auth|privvariants.The model had no simulation data, so this adds a minimal hand-made simulation (based on the reporter's DCS-7050SX3-48YC8 / EOS 4.29.2F, synthetic values) plus output and secret test data. The secret test fails against the old filter and passes with the fix.
rake testandrubocopclean.