Improve SixWind config collection and secret filtering - #3874
Open
hcaldicott wants to merge 2 commits into
Open
Conversation
Collaborator
|
Does the behaviour of the model change? It would be great to include a YAML simulation file if possible. |
Author
I will investigate the YAML simulation. The nodefault command fixes a bug as well related to reapplying configuration, but I might make a quick change to make that configurable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
This change consists of a small bugfix for password and secret redaction, as well as a new feature to support multiple config backup formats.
I received a request from another ISP to implement support for backups in the fullpath format, and this change adds some variables that allow this to be configured, while retaining the hierarchical human-readable format by default.
I have also implemented some config value validation that I have not seen implemented in other models. When invalid values are entered, I raise Oxidized::InvalidConfig. Nothing mentions this being an issue in the contributing guidelines, but I would like feedback if there are concerns about this approach to variable validation.