Add Zabbix source with Tags support - #3838
Open
SerWax wants to merge 7 commits into
Open
Conversation
Nodes can be sourced from Zabbix API. In Zabbix, add or modify template with the Macros that you then specify in Oxidized config. Example:
source:
default: zabbix
zabbix:
url: "https://zabbix.yourdomain.com/api_jsonrpc.php"
token: "yourzabbixapitoken"
template: "Cisco IOS by SNMP"
map:
username: "{$OXIDIZED_USERNAME}"
password: "{$OXIDIZED_PASSWORD}"
model: "{$OXIDIZED_MODEL}"
vars_map:
group: "{$OXIDIZED_GROUP}"
# enable: "{$OXIDIZED_ENABLE}"
Add filtering by tags to zabbix source
Comment on lines
+10
to
+26
| Nodes can be sourced from Zabbix API. In Zabbix, add or modify template with the Macros that you then specify in Oxidized config. Example: | ||
| source: | ||
| default: zabbix | ||
| zabbix: | ||
| url: "https://zabbix.yourdomain.com/api_jsonrpc.php" | ||
| token: "yourzabbixapitoken" | ||
| template: "Cisco IOS by SNMP" | ||
| map: | ||
| username: "{$OXIDIZED_USERNAME}" | ||
| password: "{$OXIDIZED_PASSWORD}" | ||
| model: "{$OXIDIZED_MODEL}" | ||
| vars_map: | ||
| group: "{$OXIDIZED_GROUP}" | ||
| enable: "{$OXIDIZED_ENABLE}" | ||
|
|
||
| - Update Zabbix source to implement filtering by tags are requested by other users. | ||
|
|
Collaborator
There was a problem hiding this comment.
Write details in docs/ not in the CHANGELOG.
Collaborator
|
@ytti - I haven't looked in Detail in this PR. as I think you were involved in specific sources for Zabbix. Do you have an opinion on it ? |
Owner
|
@ziotibia81 has not confirmed if it addresses their use-case. There seems to be some disagreement if node discovery offered satisfies both users. I think having Zabbix support would be good, but it may be difficult to find right implementation without multiple zabbix users confirming their use-case is addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Closes issue #3818 and fixes #3837