release: v1.0.7 - ship compiled plugin - #3
Merged
Merged
Conversation
- Add a "prepare" script alongside "prepack" so `dist/index.js` is built for git-based installs too. npm only runs "prepack" for `npm pack`/`npm publish`; it runs "prepare" (not "prepack") when installing the package from a git dependency, which previously left `dist/` missing and broke `main` resolution entirely for that install path. - Add test/types/public-api.test.ts, a compile-time-only check that index.d.ts (hand-written, shipped to consumers via "types") stays structurally identical to the real exports of src/index.ts. Nothing else ties the two together, and skipLibCheck plus tsconfig excluding the root index.d.ts meant a renamed, retyped, added, or removed export in either file would pass typecheck, lint, knip, tests, and the package smoke test undetected. Verified this file fails `bun run typecheck` when index.d.ts drifts and passes when it matches; it has no test() calls, so it is inert (0 assertions) under `bun test`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modulesTesting
bun run check:cibun run typecheckbun run knipbun run test:coverage(159 passed)bun run test:package