Conversation
Refactors session options in `src/preprocessor.js` and `src/parakeet.js` to ensure the `enableGraphCapture` key is completely omitted when false, rather than explicitly passing `enableGraphCapture: false`. This avoids a known ORT-web bug where passing false still triggers the graph-capture execution path and subsequently fails.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in ORT-web related to graph capture. The changes prevent the graph capture execution path from being triggered when it is explicitly disabled, and ensures that retry logic correctly handles scenarios where graph capture is unsupported. This improves the stability and reliability of ORT-web when graph capture is not desired or supported. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a bug in ORT-web related to graph capture. The changes in src/parakeet.js and src/preprocessor.js correctly modify how session options are handled, ensuring the enableGraphCapture property is only present when true and is properly removed during retries. The implementation is clean, consistent, and uses modern JavaScript features well to solve the problem.
Refactored session options in
src/preprocessor.jsandsrc/parakeet.jsto avoid explicitly passingenableGraphCapture: false.Due to a bug in
ORT-web, passing the flag as false can still inadvertently trigger the graph-capture execution path, which causes external buffer requirements and fails. This patch ensures the property is only included when explicitlytrueand that it is fully removed from retry options when the initial capture attempt fails.PR created automatically by Jules for task 16420744521506251835 started by @ysdede
Summary by Sourcery
Adjust ONNX Runtime Web session options to avoid incorrectly triggering graph capture and to cleanly remove the option on retry when unsupported.
Bug Fixes:
Enhancements: