Skip to content

[FE-69 -> develop] chore: Slack 알림에서 deployment 이름 제거 및 체크 표기 심플화 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devlasbe merged 1 commit into from
Jul 14, 2026
Merged

[FE-69 -> develop] chore: Slack 알림에서 deployment 이름 제거 및 체크 표기 심플화 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/server/src/routes/management.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,6 @@ router.openapi(routes.deployments.release.create, async (c) => {
c.executionCtx.waitUntil(
sendReleaseNotification(c.env, {
appName: app.name,
deploymentName,
label: releasedPackage.label,
appVersion: releasedPackage.appVersion,
description: releasedPackage.description,
Expand Down Expand Up @@ -1411,7 +1410,6 @@ router.openapi(routes.deployments.release.update, async (c) => {
c.executionCtx.waitUntil(
sendReleaseNotification(c.env, {
appName: app.name,
deploymentName,
label: updatedRelease.label,
appVersion: updatedRelease.appVersion,
description: updatedRelease.description,
Expand Down
8 changes: 3 additions & 5 deletions apps/server/src/utils/slack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const ACTION_EMOJI: Record<ReleaseActionType, string> = {

type ReleaseNotificationType = {
appName: string;
deploymentName: string;
label?: string;
appVersion: string;
description?: string;
Expand Down Expand Up @@ -49,11 +48,10 @@ export const sendReleaseNotification = async (
const summary = `*${info.label || "-"}* · App ${info.appVersion}`;
const body = info.description ? `${summary}\n${info.description}` : summary;

// 부가 정보는 작은 context 줄로 (Deployment · Mandatory · Disabled · 작성자)
// 부가 정보는 작은 context 줄로 (Mandatory · Disabled · 작성자)
const context = [
`📦 ${info.deploymentName}`,
`Mandatory ${info.isMandatory ? "✅" : "❌"}`,
`Disabled ${info.isDisabled ? "✅" : "❌"}`,
`Mandatory ${info.isMandatory ? "✓" : "✗"}`,
`Disabled ${info.isDisabled ? "✓" : "✗"}`,
`👤 ${info.releasedBy || "-"}`,
].join(" · ");

Expand Down
Loading