Conversation
Contributor
Author
|
Not sure about this implementation. It's better for the user to install everything by themselves, since the installation process is very dependent on device/os/configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a one-command installer for yoke on macOS, Linux, and Windows.
install.shbootstrapsrevdiffvia brew / apt / dnf / yum / pacman / tarball, warns on missinggh, registers thegithub:yokeloop/yokemarketplace throughclaude plugin marketplace add, and verifies.install.ps1mirrors the flow for Windows via winget → scoop. README and/hiadvertisecurl | bashandirm | iexentry points with a candor note about remote-script execution.Closes #4
Attention
install.sh:193-218sudo_prefix/sudo_prime— opportunistic TTY-gated sudo escalation. Critical for thecurl | bashflow on Linux; post-review fix re-gates on[ -t 1 ]or warmsudo -n trueand resolves once per step into$SUDOso a subshellexit 4can't be swallowed.install.sh:256-285install_revdiff_tarball— least-privilege escape hatch with anXDG_BIN_HOMEwritability probe.install.sh:297-302brew tap probe — capture-then-filter pattern to dodge apipefailfalse negative.install.ps1:5-22param block +$script:IsVerbose— custom[switch]$Verbosecollides with[CmdletBinding()]; removed, and$script:IsVerbose = ($VerbosePreference -ne 'SilentlyContinue') -or $PSBoundParameters.ContainsKey('Verbose')is now the source of truth.install.ps1:127-138winget fallback — "already installed" / "no applicable update" exit codes re-probed againstGet-Command revdiff.install.ps1:183-190Test-MarketplaceRegistered— multiline regex ([regex]::new('(?m)...')) overclaude plugin marketplace list.README.md/skills/hi/SKILL.mdInstallation blocks — byte-identical per Req 14, with the new candor note.Design decisions
claude plugin marketplace add/list/remove. The task file'sclaude marketplace addis not a real subcommand; verified againstclaude plugin marketplace --help. Sluggithub:yokeloop/yokepreserved.[ -t 1 ]or warmsudo -n truecache; resolve once per step into a$SUDOlocal; return non-zero instead ofexit 4so a subshell can't swallow the escalation failure.revdiffandghbinaries in place; print a manual-removal hint.install.sh. No sourced modules — required forcurl | bash.Questions
/releases/download/v0.1.0/install.sh) as the default install command?--versionon a release branch emit the git commit SHA alongside0.1.0?scripts/test-install-docker.shsmoke harness worth landing in this PR, or deferred to a follow-up CI ticket?Risks
main. Futuremaincommits change the install surface for anyone piping the URL. Consider tagging releases.tar --no-same-owneris GNU; the installer falls back on rejection. Confirm on older macOS (pre-10.15) if still in scope.pwshparse check deferred (not on the macOS host used here).sudois absent AND not root AND stderr has no TTY, the script exits 4. The right call, but documented only in the error message.Test plan
Automated (already green):
bash -n install.sh→ rc=0pnpm run format:check→ cleanclaude marketplace add→ 0 matches repo-wide./install.sh --help,-h,--version→ rc=0 before preflightPATH="/tmp/empty:$PATH" ./install.sh→ rc=2 with Req-4 messageManual — please run before merge:
./install.sh→ exit 0;claude plugin marketplace listshows yoke;revdiff --versionprints a version.revdiff already installedandyoke marketplace already registered; no network connects../install.sh --uninstall→ exit 0; marketplace row gone;revdiffbinary preserved; manual-removal hint printed.curl -fsSL file://.../install.sh | bashwithsudoavailable → exit 0;.debpath fires; sudo escalation works via the[ -t 1 ]gate.claude→ exit 0;.rpmpath fires.powershell -NoProfile -Command '. .\install.ps1 -Help'→ exit 0; no reserved-parameter parse error.winget installreturns "already installed" exit code → log demotes to debug; Scoop fallback not attempted.Changes
install.shinstall.ps1README.md## Installationas one-liner flow; trimmed revdiff### Install; added candor noteskills/hi/SKILL.mddocs/ai/4-install-script/4-install-script-task.mddocs/ai/4-install-script/4-install-script-plan.mddocs/ai/4-install-script/4-install-script-report.mddocs/ai/4-install-script/4-install-script-review.mdStats: 8 files, +1443 / -5.
Commits
8f79707Add one-command install and activation script for yoke and its dependencies #4 docs(4-install-script): add task definitiona30524aAdd one-command install and activation script for yoke and its dependencies #4 docs(4-install-script): add implementation plana2ebc57Add one-command install and activation script for yoke and its dependencies #4 feat(4-install-script): add install.ps1 installer for WindowsaaaaacfAdd one-command install and activation script for yoke and its dependencies #4 feat(4-install-script): add install.sh installer for macOS and Linux23a3adfAdd one-command install and activation script for yoke and its dependencies #4 fix(4-install-script): address spec-review feedback on install.ps162bbccaAdd one-command install and activation script for yoke and its dependencies #4 docs(4-install-script): switch install docs to one-command flow40be260Add one-command install and activation script for yoke and its dependencies #4 refactor(4-install-script): simplify installer scripts51a37cfAdd one-command install and activation script for yoke and its dependencies #4 docs(4-install-script): add execution reporta6259abAdd one-command install and activation script for yoke and its dependencies #4 fix(4-install-script): fix 14 review issues9d9bd3fAdd one-command install and activation script for yoke and its dependencies #4 docs(4-install-script): add review reportValidation
pnpm run format:check✅ cleanbash -n install.sh✅ rc=0head -1 skills/*/SKILL.md✅ every SKILL.md starts with---rg -F 'claude marketplace add'across repo ✅ 0 matchesrg -F 'claude plugin marketplace add github:yokeloop/yoke' install.sh install.ps1✅ 2 matchesrg -F '/plugin marketplace add umputun/revdiff' README.md✅ 1 match (preserved)rg -F '/plugin install revdiff@umputun-revdiff' README.md✅ 1 match (preserved)Lint / type-check / test / build: N/A (markdown-only plugin; only
format:checkexists).