Skip to content

Compatibility with Symfony 8.x - #44

Merged
yann-eugone merged 2 commits into
mainfrom
sonata-admin-v5
Oct 26, 2026
Merged

Compatibility with Symfony 8.x#44
yann-eugone merged 2 commits into
mainfrom
sonata-admin-v5

Conversation

@yann-eugone

@yann-eugone yann-eugone commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

See #43

@yann-eugone yann-eugone mentioned this pull request Dec 10, 2025
Open
@jean-gui

jean-gui commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Hi @yann-eugone, what's the status of this PR? I have tested it locally with Symfony 8 but SonataAdmin 4.42 (which I believe is the current release) and it seems to work fine.

@yann-eugone

yann-eugone commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Hi @jean-gui
As you can see, tests were failing, but it's not the main issue
I asked the author of the issue related to test the changes on it's side, but never has any feedback

@phiamo

phiamo commented Sep 13, 2026

Copy link
Copy Markdown

Tested locally as part of a Symfony 8 trial on Sonata Admin 4.42 (myrecordings). VCS-pinned to this PR branch (dev-pull/44/head) for composer resolution. Happy to share results if useful for unblocking merge.

@yann-eugone
Stick to SonataAdmin 4.x until 5.x is released as stable
c771927 
- SonataAdmin 5.x is not tagged yet: require ^4.10, which supports Symfony 8.x
- ^4.10 is the first version where assertObjectExists() returns the object
- Test lowest dependencies, and upcoming SonataAdmin 5.x-dev (allowed to fail)
@yann-eugone yann-eugone changed the title Compatibility with SonataAdmin 5.x & Symfony 8.x Compatibility with Symfony 8.x Oct 26, 2026
@yann-eugone

yann-eugone commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

SonataAdmin 5.x is still not released as stable, so this PR now only brings Symfony 8.x compatibility, on SonataAdmin 4.x (^4.10)
tests were failing because the CI was requiring SonataAdmin ^5.0, which does not exist yet
a new CI job runs the tests against the SonataAdmin 5.x-dev branch (allowed to fail), it's green for now
SonataAdmin 5.x support will come once it's tagged, #43 stays open for that
/cc @jean-gui @phiamo @tillackt

@yann-eugone
yann-eugone merged commit 1da25cc into main Oct 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yann-eugone @jean-gui @phiamo