Fix: Load backdrop overlaps nodes#129
Open
Tilix4 wants to merge 3 commits into
Open
Conversation
BigRoy
added
type: enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes template-loading placement so that backdrops-only templates don’t overlap existing nodes in scenes without backdrops, and reduces the horizontal offset applied when resolving overlaps.
Changes:
- Treat existing nodes in
Topas occupied space during overlap prevention (in addition to existing backdrops). - Adjust overlap resolution step to place new content immediately after the overlapping rect plus the configured gap (instead of advancing by a full “slot width”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| occupiedRects.push(rect); | ||
| }); | ||
|
|
||
|
|
Comment on lines
+463
to
+467
| // Also treat existing top-level nodes as occupied space so that new | ||
| // content is not placed on top of them even when no backdrops are present. | ||
| var newNodeSet = {}; | ||
| newNodes.forEach(function(n) { newNodeSet[n] = true; }); | ||
| node.subNodes("Top").forEach(function(nodePath) { |
Contributor
Author
There was a problem hiding this comment.
This is wrong. node.subNodes("Top") returns the list of nodes at the level string given as argument.
Comment on lines
581
to
585
| if (!overlapRect) { | ||
| break; | ||
| } | ||
| candidateLeft += slotWidth; | ||
| candidateLeft = overlapRect.right + PARENT_BACKDROP_GRID_GAP; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fixing template with backdrops only in a scene containing only nodes overlap at loading. Also reducing the distance between the original content and the loaded one.
Testing notes: