Make database settings configurable #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for configuring the database connection settings using a config.yml file, following the same format as ynoserver. Much of the config code has been adapted from ynoserver.
knuxify
force-pushed
the
db-custom-creds
branch
from
6726853 to
c9fe47e
Compare
Desdaemon
reviewed
Dec 30, 2025
| func Init() { | ||
| conn, err := sql.Open("mysql", "yno@unix(/run/mysqld/mysqld.sock)/ynodb?parseTime=true") | ||
| func InitDatabaseConn(user, password, addr, database string) { | ||
| conn, err := sql.Open("mysql", fmt.Sprintf("%s:%s@%s/%s?parseTime=true", user, password, addr, database)) |
Contributor
There was a problem hiding this comment.
This does not handle the original case with passwordless auth, might wanna combine user and password into one config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for configuring the database connection settings using a config.yml file, following the same format as ynoserver. Much of the config code has been adapted from ynoserver.
(I don't have a ton of Go experience, reviews/pointers as to how this could be done better are appreciated :D)