Conversation
Member
s1lver
commented
Feb 7, 2026
s1lver
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fixed issues |
Co-authored-by: Bizley <pawel.bizley@gmail.com>
# Conflicts: # Makefile # composer.json # src/drivers/db/Command.php # src/drivers/db/Queue.php # src/drivers/file/Command.php # src/drivers/redis/Command.php # src/drivers/sqs/Command.php # tests/app/config/main.php # tests/docker-compose.yml # tests/drivers/db/TestCase.php
Co-authored-by: Lucas Bartholemy <luke-@users.noreply.github.com> Co-authored-by: Mikhail <mike.grechanik@gmail.com> Co-authored-by: Wilmer Arambula <42547589+terabytesoftw@users.noreply.github.com> Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # CHANGELOG.md # composer.json # src/InvalidJobException.php # src/Queue.php # tests/docker/php/5.6/Dockerfile # tests/docker/php/7.0/Dockerfile # tests/docker/php/7.1/Dockerfile # tests/docker/php/7.2/Dockerfile
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #545 +/- ##
=========================================
Coverage ? 46.54%
Complexity ? 499
=========================================
Files ? 44
Lines ? 1579
Branches ? 0
=========================================
Hits ? 735
Misses ? 844
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
terabytesoftw
approved these changes
Feb 7, 2026
mspirkov
approved these changes
Feb 7, 2026
mspirkov
left a comment
mspirkov
left a comment
There was a problem hiding this comment.
I understand that this is just a 3.0 merge with the master. I just thought it was appropriate to mention a few things.
Comment on lines
+9
to
+19
| - ".editorconfig" | ||
| - ".gitattributes" | ||
| - ".github/CONTRIBUTING.md" | ||
| - ".github/FUNDING.yml" | ||
| - ".github/SECURITY.md" | ||
| - ".gitignore" | ||
| - "docker-compose.yml" | ||
| - "LICENSE.md" | ||
| - "README.md" | ||
| - "CHANGELOG.md" | ||
| - "UPGRADE.md" |
There was a problem hiding this comment.
Suggested change
| - ".editorconfig" | |
| - ".gitattributes" | |
| - ".github/CONTRIBUTING.md" | |
| - ".github/FUNDING.yml" | |
| - ".github/SECURITY.md" | |
| - ".gitignore" | |
| - "docker-compose.yml" | |
| - "LICENSE.md" | |
| - "README.md" | |
| - "CHANGELOG.md" | |
| - "UPGRADE.md" | |
| - 'docs/**' | |
| - '.github/CONTRIBUTING.md' | |
| - '.github/FUNDING.yml' | |
| - '.github/SECURITY.md' | |
| - 'README.md' | |
| - 'CHANGELOG.md' | |
| - 'LICENSE.md' | |
| - 'UPGRADE.md' | |
| - '.gitignore' | |
| - '.gitattributes' | |
| - '.editorconfig' | |
| - 'docker-compose.yml' | |
| - 'Makefile' |
Comment on lines
+6
to
+11
| - 'docs/**' | ||
| - 'README.md' | ||
| - 'CHANGELOG.md' | ||
| - 'UPGRADE.md' | ||
| - '.gitignore' | ||
| - '.gitattributes' |
There was a problem hiding this comment.
Suggested change
| - 'docs/**' | |
| - 'README.md' | |
| - 'CHANGELOG.md' | |
| - 'UPGRADE.md' | |
| - '.gitignore' | |
| - '.gitattributes' | |
| - 'docs/**' | |
| - '.github/CONTRIBUTING.md' | |
| - '.github/FUNDING.yml' | |
| - '.github/SECURITY.md' | |
| - 'README.md' | |
| - 'CHANGELOG.md' | |
| - 'LICENSE.md' | |
| - 'UPGRADE.md' | |
| - '.gitignore' | |
| - '.gitattributes' | |
| - '.editorconfig' |
Comment on lines
+4
to
+9
| - 'docs/**' | ||
| - 'README.md' | ||
| - 'CHANGELOG.md' | ||
| - 'UPGRADE.md' | ||
| - '.gitignore' | ||
| - '.gitattributes' |
There was a problem hiding this comment.
Suggested change
| - 'docs/**' | |
| - 'README.md' | |
| - 'CHANGELOG.md' | |
| - 'UPGRADE.md' | |
| - '.gitignore' | |
| - '.gitattributes' | |
| - 'docs/**' | |
| - '.github/CONTRIBUTING.md' | |
| - '.github/FUNDING.yml' | |
| - '.github/SECURITY.md' | |
| - 'README.md' | |
| - 'CHANGELOG.md' | |
| - 'LICENSE.md' | |
| - 'UPGRADE.md' | |
| - '.gitignore' | |
| - '.gitattributes' | |
| - '.editorconfig' |
Comment on lines
+25
to
+28
| <exclude> | ||
| <directory>./src/debug</directory> | ||
| <directory>./src/gii</directory> | ||
| </exclude> |
There was a problem hiding this comment.
Is this really the right thing to do? I think that in this case, the coverage report is not accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.