Fix reusing the previous session ID in Session::open() in long-running workers - #90
Closed
klsoft-web wants to merge 1 commit into
Closed
klsoft-web wants to merge 1 commit into
klsoft-web wants to merge 1 commit into
Annotations
10 warnings and 1 notice
|
Run roave infection.:
src/Flash/Flash.php#L151
Escaped Mutant for Mutator "MethodCallRemoval":
@@ @@
*/
private function fetch(): array
{
- // Ensure session is active (and has id).
- $this->session->open();
+
if ($this->sessionId !== $this->session->getId()) {
$this->sessionId = $this->session->getId();
$this->updateCounters();
|
|
Run roave infection.:
src/Flash/Flash.php#L120
Escaped Mutant for Mutator "ArrayItemRemoval":
@@ @@
{
$flashes = $this->session->get(self::FLASH_PARAM, []);
if (!is_array($flashes)) {
- $flashes = [self::COUNTERS => []];
+ $flashes = [];
}
$counters = $flashes[self::COUNTERS] ?? [];
if (!is_array($counters)) {
|
|
Run roave infection.:
src/Flash/Flash.php#L81
Escaped Mutant for Mutator "IncrementInteger":
@@ @@
{
$flashes = $this->fetch();
/** @psalm-suppress MixedArrayAssignment */
- $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : 0;
+ $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : 1;
if (empty($flashes[$key])) {
$flashes[$key] = [$value];
} elseif (is_array($flashes[$key])) {
|
|
Run roave infection.:
src/Flash/Flash.php#L81
Escaped Mutant for Mutator "DecrementInteger":
@@ @@
{
$flashes = $this->fetch();
/** @psalm-suppress MixedArrayAssignment */
- $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : 0;
+ $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : -1;
if (empty($flashes[$key])) {
$flashes[$key] = [$value];
} elseif (is_array($flashes[$key])) {
|
|
Run roave infection.:
src/Flash/Flash.php#L76
Escaped Mutant for Mutator "TrueValue":
@@ @@
$flashes[$key] = $value;
$this->save($flashes);
}
- public function add(string $key, $value = true, bool $removeAfterAccess = true): void
+ public function add(string $key, $value = false, bool $removeAfterAccess = true): void
{
$flashes = $this->fetch();
/** @psalm-suppress MixedArrayAssignment */
|
|
Run roave infection.:
src/Flash/Flash.php#L70
Escaped Mutant for Mutator "IncrementInteger":
@@ @@
{
$flashes = $this->fetch();
/** @psalm-suppress MixedArrayAssignment */
- $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : 0;
+ $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : 1;
$flashes[$key] = $value;
$this->save($flashes);
}
|
|
Run roave infection.:
src/Flash/Flash.php#L70
Escaped Mutant for Mutator "DecrementInteger":
@@ @@
{
$flashes = $this->fetch();
/** @psalm-suppress MixedArrayAssignment */
- $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : 0;
+ $flashes[self::COUNTERS][$key] = $removeAfterAccess ? -1 : -1;
$flashes[$key] = $value;
$this->save($flashes);
}
|
|
Run roave infection.:
src/Flash/Flash.php#L65
Escaped Mutant for Mutator "TrueValue":
@@ @@
$this->save($flashes);
return $list;
}
- public function set(string $key, $value = true, bool $removeAfterAccess = true): void
+ public function set(string $key, $value = false, bool $removeAfterAccess = true): void
{
$flashes = $this->fetch();
/** @psalm-suppress MixedArrayAssignment */
|
|
Run roave infection.:
src/Flash/Flash.php#L54
Escaped Mutant for Mutator "LessThan":
@@ @@
continue;
}
$list[$key] = $value;
- if ($flashes[self::COUNTERS][$key] < 0) {
+ if ($flashes[self::COUNTERS][$key] <= 0) {
// Mark for deletion in the next request.
$flashes[self::COUNTERS][$key] = 1;
}
|
|
Run roave infection.:
src/Flash/Flash.php#L33
Escaped Mutant for Mutator "LessThan":
@@ @@
if (!isset($flashes[$key], $flashes[self::COUNTERS][$key])) {
return null;
}
- if ($flashes[self::COUNTERS][$key] < 0) {
+ if ($flashes[self::COUNTERS][$key] <= 0) {
// Mark for deletion in the next request.
$flashes[self::COUNTERS][$key] = 1;
$this->save($flashes);
|
|
"The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see https://github.com/actions/runner-images/issues/14748"
|
background
wait
wait-all
cancel
parallel
Loading