Skip to content

chore: remove unused ensureContactAssignment helper - #401

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-ensurecontactassignment-helper-86879c
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-ensurecontactassignment-helper-86879c

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Removed ensureContactAssignment from contact.service.ts and dropped the
now-stale specific reference to it in the requireSendAccess doc comment
in send-access.service.ts (the general warning against pre-transaction
assignment claims is kept).

The function had zero production callers: it was the original "auto-assign
on first reply" mechanism, later superseded by requireSendAccess, which
migrated every call-site (send.ts, scheduled.ts, conversations/messages.ts)
but left the definition behind. The send-access warning comment explicitly
told callers NOT to use it, and leaving it in place would mislead by
looking like a simpler alternative to the lock-aware guard while
reintroducing the TOCTOU race SLA enforcement was built to close.

History

  • Last materially changed January 2026 (@setkyar)

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from setkyar September 15, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant