chore: remove unused ensureContactAssignment helper - #401
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
ensureContactAssignmentfrom contact.service.ts and dropped thenow-stale specific reference to it in the
requireSendAccessdoc commentin send-access.service.ts (the general warning against pre-transaction
assignment claims is kept).
The function had zero production callers: it was the original "auto-assign
on first reply" mechanism, later superseded by
requireSendAccess, whichmigrated every call-site (send.ts, scheduled.ts, conversations/messages.ts)
but left the definition behind. The send-access warning comment explicitly
told callers NOT to use it, and leaving it in place would mislead by
looking like a simpler alternative to the lock-aware guard while
reintroducing the TOCTOU race SLA enforcement was built to close.
History
Dead Code PRs can be configured here.